Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Without authorization comments. #3829

Closed
Evgura opened this issue Jun 6, 2019 · 19 comments
Closed

Without authorization comments. #3829

Evgura opened this issue Jun 6, 2019 · 19 comments
Assignees
Labels
type: bug A problem that should not be happening
Milestone

Comments

@Evgura
Copy link

Evgura commented Jun 6, 2019

eddv

If you leave comments without logging in we get this...

erty

If you then log in it turns out here that...

edss

edcaa

Comments in the admin set up, recalculation did.

@Moc
Copy link
Member

Moc commented Jun 6, 2019

I am not sure I understand your issue.

From the title I understand that there is unauthorized comments. I assume that this means that Guests are able to post comments, even though you do not want this.

In "Admin Area > Comments Manager > Preferences", the setting Allow anonymous posting? is turned off?

Or are you referring to the content of the comment? In the first screenshot? If so, please set to English or translate to English.

@Moc Moc added the status: awaiting feedback This issue may be fixed and is awaiting the original poster to confirm the fix. label Jun 6, 2019
@Evgura
Copy link
Author

Evgura commented Jun 6, 2019

Yes, comments are allowed without registration.
What with the English language without it turns out the same. Also, the commentator icon is replaced with mine.
Previously, you could write just like that.

@Moc
Copy link
Member

Moc commented Jun 6, 2019

I cannot confirm this. I get this when I am not logged in:

image

Are you using the latest files?

@Evgura
Copy link
Author

Evgura commented Jun 6, 2019

e107
Версия 2.2.2 (git)

@Jimmi08
Copy link
Contributor

Jimmi08 commented Jun 6, 2019

@Moc
I think he is trying to say:

  • quests can comment (it's ON)
  • if you post comment as quest, you get time of posting 49 years ago
  • if you post comment as quest, quest content of comment is not visible
  • as soon as you log in, all icons on comments are changed to user icon
  • as soon as you log in, time and comment content is visible.

I could be wrong...
Maybe this is related to that php 7.3 change
@Evgura on live site use max official 2.2.1 release from e107.org, not GitHub version

@Evgura
Copy link
Author

Evgura commented Jun 6, 2019

@Jimmi08 Версия PHP 7.2.18
Maybe it is connected with the engine version 2.2.2

@Jimmi08
Copy link
Contributor

Jimmi08 commented Jun 6, 2019

@Evgura
Very probably, I meant - after 2.2.1 release there was a big change in the core. If this is related, very good that you find it. But until full testing, you shouldn't use 2.2.2 on live site.

#2146

Did I get correct what you had on mind?

@Evgura
Copy link
Author

Evgura commented Jun 6, 2019

@Jimmi08 Maybe it has something to do with it. I'll try to roll back to 2.2.1

@Moc Moc added the status: testing required Someone needs to confirm this issue's existence and write a test to prevent the fix from regressing. label Jun 7, 2019
@Evgura
Copy link
Author

Evgura commented Jun 9, 2019

@Jimmi08 On version of engine 2.2.1, too, not earned.
2.2.0 not found where download.
It turned out to run everything without errors on version 2.1.9

The theme of the website BS_Magazine_01

@Moc
Copy link
Member

Moc commented Jun 9, 2019

All releases are available here https://sourceforge.net/projects/e107/files/e107/ and here https://github.com/e107inc/e107/releases

It would be very interesting to test this on v2.2.0.

@Evgura
Copy link
Author

Evgura commented Jun 9, 2019

@Moc With the version of CMS 2.2.0 works fine.

@Moc
Copy link
Member

Moc commented Jun 12, 2019

I really am unable to reproduce this on my test installations. Using PHP 7.2 and 7.3, and the BS_Magazine_01 theme.

In Admin Area > Comment manager > Preferences:

  • Allow users to post comments: On
  • Allow anonymous posting?: Off

Avatars are working fine, logged in and logged out.
When not logged in, I get the message saying that I should sign up first.

If I switch the anonymous posting to On, the name field appears and I can enter a comment.

Not sure what else I can do here.... Can anyone else reproduce this issue?

@Evgura
Copy link
Author

Evgura commented Jun 12, 2019

@Moc I do not understand, does not work on this subject (BS_Magazine_01), other fine.

@Moc
Copy link
Member

Moc commented Oct 11, 2019

Is anyone else able to reproduce this?

@Jimmi08 ?

@Jimmi08
Copy link
Contributor

Jimmi08 commented Oct 11, 2019

PHP 7.2.16
latest github (sync yesterday)
Temp set:
image

Comment as Anonymous.
Button submit - no refresh, the second click - warning about the duplicate post

Result still the same
image

I found this too:
#3971

@Jimmi08
Copy link
Contributor

Jimmi08 commented Oct 11, 2019

@Moc test it with Allow anonymous posting?: ON

@Moc Moc self-assigned this Oct 12, 2019
@Moc Moc removed the status: awaiting feedback This issue may be fixed and is awaiting the original poster to confirm the fix. label Oct 12, 2019
@Moc
Copy link
Member

Moc commented Oct 12, 2019

Reproduced. Working on a fix.

@Moc Moc closed this as completed in ed56f04 Oct 12, 2019
@Moc
Copy link
Member

Moc commented Oct 12, 2019

Turns out I created the bug when trying to fix another bug (#3813).
This issue should be fixed now with the latest files, please test and let me know.

@Moc Moc added type: bug A problem that should not be happening and removed status: testing required Someone needs to confirm this issue's existence and write a test to prevent the fix from regressing. labels Oct 12, 2019
@Moc Moc added this to the e107 2.2.2 milestone Oct 12, 2019
@Moc
Copy link
Member

Moc commented Oct 12, 2019

There are still two issues, but these are separate issues:

  • Directly after entering an anonymous comment, the javascript that shows the newly added comment is not run. Therefore nothing seems to happen when the 'Submit comment' button is clicked, but the comment is added. After refresh, the comment appears. This works fine when logged in.

  • the datestamp directly after a comment is 'ago'. This is a bug in the relative date parsing. Will look into that. Same issue occurs in for example forum posts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A problem that should not be happening
Projects
None yet
Development

No branches or pull requests

3 participants