Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Render avatars for chatbox_menu plugin posts in chat.php #3630

Closed
arunshekher opened this issue Jan 18, 2019 · 4 comments
Closed
Labels
type: enhancement An improvement or new feature request

Comments

@arunshekher
Copy link
Member

Would like to see a custom template-able list view for chat.php page with user avatars and user profile links rendered just like in the chatbox_menu. But this plugin has been left un-updated for so long, if there are specific reasons for it someone please let me know.

I worked a bit on it and was able to add an external template in templates directory inside this plugin and a shortcode class following the e107 conventions advised in the developer manual. A screenshot of the result is posted below. Is it acceptable @CaMer0n et al? If yes shall I submit a merge request for it? Thanks

screen shot 2019-01-19 at 12 51 31 am

@CaMer0n
Copy link
Member

CaMer0n commented Jan 18, 2019

@arunshekher Looks fine. Pull-request welcome.

@Moc
Copy link
Member

Moc commented Jan 19, 2019

Looking good! Great work!

@arunshekher
Copy link
Member Author

@CaMer0n & @Moc, Just submitted these changes via #3631

@Moc Moc added the type: enhancement An improvement or new feature request label Jan 23, 2019
@CaMer0n
Copy link
Member

CaMer0n commented Jan 31, 2019

Merged! Closing.

@CaMer0n CaMer0n closed this as completed Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement An improvement or new feature request
Projects
None yet
Development

No branches or pull requests

3 participants