Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for hosting providers that disable readfile() #3528

Closed
Deltik opened this issue Oct 31, 2018 · 3 comments · Fixed by #3529
Closed

Add support for hosting providers that disable readfile() #3528

Deltik opened this issue Oct 31, 2018 · 3 comments · Fixed by #3529

Comments

@Deltik
Copy link
Member

Deltik commented Oct 31, 2018

Issue came from Gitter, where @wonozhong had this issue:

screenshot_2018-10-31 gitter

There are two usages of readfile() in e107 that can be abstracted to use an alternative to readfile():

screenshot_20181031_042308

@CaMer0n
Copy link
Member

CaMer0n commented Nov 6, 2018

Hoping this change is unrelated to #3520

@Deltik
Copy link
Member Author

Deltik commented Nov 6, 2018

@CaMer0n: #3520 looks unrelated.

In that issue, the user referenced this thumbnail URL:

http://www.outlawsracing.com/thumb.php?src=e_MEDIA_IMAGE%2F2018-10%2Fe-packchampweb.png&w=800&h=0

That translates to this source URL:

http://www.outlawsracing.com/e107_images/2018-10/e-packchampweb.png

At the time of writing, that URL returned HTTP 404, which explains the by-design behavior of thumb.php redirecting to https://placehold.it/800x0.

@CaMer0n
Copy link
Member

CaMer0n commented Nov 7, 2018

Thank you @Deltik !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants