-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Docker (OCI) repositories #1618
Comments
If someone has some experience with it, it'd be nice to prepare list of routes with short description per each endpoint, so we could create a minimal working implementation on top of that. |
For future investigation I've collected resources, that can be useful. It seems pretty straight forward to implement, however the flow of uploading is quite different from Maven. Official spec Third party |
Thanks, Docker support is something I'd really like to see in 4.x (at some point) :) I'll probably try to bootstrap some sort of proof of concept, or browse GitHub to check existing projects, to get a brief overview on how the minimal working impl would look like 🙏 |
I did some research and created descriptions for the endpoints, which should help visualize how we should approach the implementation of this specification, at least to some extent. NotesDefinitions
Blob Upload StrategiesWe have the option to support two blob upload strategies. We can either support one or both at the same time, but this will certainly affect the implementation time. 1-STEPThe simplest option is to support a single request via POST, which uploads the blob to the registry. This is done by making a Advantages
Disadvantages
2-STEPThis approach is slightly more complex. First, we make a Advantages
Disadvantages
ConclusionsI think we should implement both approaches due to the different needs they address. The specification mentions that some implementations do not support the 1-STEP option, so we could treat it as an optional feature. If we were to support only one option, it would likely be better to use the 2-STEP approach – it has greater long-term benefits. Endpoints (Incompleted)GET
|
Thanks to @zrdzn, we were able to prepare a working prototype of Docker repository: Considering our current resources & value of this feature, I'm including basic Docker repository support in the scope of 4.x: |
Request details
To support OCI repositories for e.g. Docker, we need to figure out how to do that. Specification:
The text was updated successfully, but these errors were encountered: