Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make notification clickable #438

Closed
vivadavid opened this issue May 2, 2023 · 11 comments
Closed

Make notification clickable #438

vivadavid opened this issue May 2, 2023 · 11 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@vivadavid
Copy link

What happened?

Hi,

  1. I run NormCap.
  2. I select some text.
  3. I get the Windows 11 notification panel with the recognized text.
  4. I click on the panel to read the whole recognized text.
  5. Nothing happens: the panel is gone.

I've tried to generate the debug log, but when I type NormCap.exe -v debug, the terminal reports an error:

NormCap.exe : El término 'NormCap.exe' no se reconoce como nombre de un cmdlet, función, archivo de script o programa
ejecutable.

How did you install NormCap?

MSI installer (Windows)

Operating System + Version?

Windows 11 (22H2)

[Linux only] Display Server (DS) + Desktop environment (DE)?

No response

Debug log output?

No response

@vivadavid vivadavid added bug Something isn't working triage Needs confirmation and priotization labels May 2, 2023
@dynobo
Copy link
Owner

dynobo commented May 7, 2023

Hi @vivadavid , thanks for reporting. I think there is a misunderstanding: the notification of NormCap is not supposed to be clicked, it will do nothing (the default behavior of Windows might be to close/hide the notification in that case).

The purpose of the notification is purely informational: it notifies the user, when the text recognition finished.

The recognized text itself ends up in the system clipboard only. To access it, you can just paste it somewhere, e.g. open "Notepad" and press <ctrl> + v (or click "Edit" -> "Paste" in the menu).

Does this help you / solve your issue?

PS: I really like the idea of a clickable notification, but afaik Qt, the UI library used to build NormCap, doesn`t support it. Actually, it looks like it could be implemented! I'll think about! :-)

PPS: To get the debug information, you need to specify the full path of NormCap.exe, otherwise it is not found. Try pasting the full following line:

%LOCALAPPDATA%\Programs\dynobo\NormCap\NormCap.exe -v debug

Does this work for you.

@vivadavid
Copy link
Author

Hi, @dynobo ,

Thank you for your message.

  1. I thought it was meant to be clickable. It would certainly be nice if you could implement it, as a way to check the text you've just OCRd. Also, you could manually correct little mistakes and select part of the text if necessary.

  2. When I typed NormCap.exe -v debug, I was actually in the folder where the file was located: that's why I don't understand why it didn't work. I'll check what I'm doing wrong as far as the terminal is concerned.

@vivadavid
Copy link
Author

Now that I remember, my intention when clicking on the notification panel was not only to see the text, but also to access the settings. Is there currently a way to change the settings of the programme to, for example, add and remove languages?

@vivadavid
Copy link
Author

Hi, just a quick note to let you know that next time I need to provide you with a log, I'll be able to do it. On the Windows Terminal, I had opened a tab on the Powershell instead of doing it on the Command Prompt. I was confused with all these different tools.

@dynobo
Copy link
Owner

dynobo commented May 9, 2023

Is there currently a way to change the settings of the programme to, for example, add and remove languages?

Yes, the menu is behind the red cog wheel that appears on your main monitor in the top right corner during "capture" (red borders around screen).

I already know, that this isn't super obvious, #443 tries to mitigate that. However, if you have other ideas how to make NormCap more intuitive, let me know!

@dynobo dynobo added enhancement New feature or request and removed bug Something isn't working triage Needs confirmation and priotization labels May 13, 2023
@dynobo dynobo changed the title Notification panel not accessible Make notification clickable May 13, 2023
@dynobo dynobo added this to the 0.5.0 milestone Aug 28, 2023
@dynobo
Copy link
Owner

dynobo commented Oct 8, 2023

This has been implemented for macOS and Windows and released.

The action when clicking on the notification depends on the detected text-type:

  • Single-Line, Multi-Line, Characters: Open as new document in default text editor.
  • URLs: Open in new tab in default browser.
  • Mail-addresses: Compose a new mail with the default mail app.

It would be great if you could test the new feature in NormCap v0.5.0-beta1 and report back, if you like it.

@vivadavid
Copy link
Author

Hi,

All three options work fine! Thanks for adding this feature!

@vivadavid
Copy link
Author

Actually, I've just noticed it doesn't work when raw mode is selected (I've tried all three scenarios: notepad, web browser and e-mail client).

@dynobo
Copy link
Owner

dynobo commented Oct 8, 2023

Actually, I've just noticed it doesn't work when raw mode is selected

Great finding, thanks!

Obviously, due to the nature of the raw mode it won't detect mails or URLs, so these actions can't be triggered. But instead, all captured text should be shown in the editor. Easy fix, probably can be shipped in the next release 🙂

@dynobo dynobo modified the milestones: 0.5.0b1, 0.5.0 Oct 8, 2023
@vivadavid
Copy link
Author

Actually, I've just noticed it doesn't work when raw mode is selected

Great finding, thanks!

Obviously, due to the nature of the raw mode it won't detect mails or URLs, so these actions can't be triggered. But instead, all captured text should be shown in the editor. Easy fix, probably can be shipped in the next release 🙂

Glad I was able to help and thanks for fixing it! :-)

@dynobo dynobo self-assigned this Oct 25, 2023
@dynobo dynobo modified the milestones: 0.5.0, 0.5.0b2 Oct 25, 2023
@dynobo dynobo modified the milestones: 0.5.0b2, 0.5.0 Nov 5, 2023
@dynobo
Copy link
Owner

dynobo commented Dec 17, 2023

Implemented for macOS and Windows in the latest release.

On Linux, it seems like the messageClicked() signal is not supported. If someone knows a solution for this, please let me know!

@dynobo dynobo closed this as completed Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants