Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notifcation/splash screen to show whats happenig after screenshot selection #27

Closed
dynobo opened this issue Sep 10, 2019 · 8 comments
Assignees
Labels
backlog This issue is on the roadmap
Milestone

Comments

@dynobo
Copy link
Owner

dynobo commented Sep 10, 2019

E.g.:

  • "Detecting text..." -> "Parsing email.." -> "Trigger action..."
  • Preferably icons only, no text
@dynobo dynobo added the backlog This issue is on the roadmap label Sep 10, 2019
@dynobo dynobo self-assigned this Sep 10, 2019
@dynobo dynobo added this to the 0.2 Alpha milestone Sep 10, 2019
@ashishpatel1992
Copy link
Contributor

Hi @dynobo
I have worked on a feature that pushes a notification on Windows that text is copied to clipboard
Here is sample notification. Although I would like you to suggest me the title.
(In this example for the title I have chosen to display noarmcap - Text Captured
below that, I have shown part of the text copied in a single line and also handled the case when no text is detected)
image

When no text is present to be copied

image

I think it really looks nice informing that content is copied to their clipboard.
So I have two ideas for the copied text in the notification:

  1. Show the partial copied text
  2. Inform the user top use CTRL+V to paste the text

image

Let me know your thoughts on this. If the text seems fine to you I can send you a merge request.

@dynobo
Copy link
Owner Author

dynobo commented Nov 1, 2020

Thanks for your proposal @ashishpatel1992. I like your idea to use the systems notification system for displaying this information! I'll do some research, if I can find a cross-platform python package that can provide this functionality. :-)

@ashishpatel1992
Copy link
Contributor

Hi,
The current notification displayed is having the wrong application name Python Application (notify.py)
image

I am sending you a merge request with application name and version.

image

@dynobo
Copy link
Owner Author

dynobo commented Nov 2, 2020

Thanks, @ashishpatel1992 !

One question: I'm hesitating to publish 0.1.6 as release, because I discovered an issue on Windows: Shortly before the notification appears, a Powershell-Window pops up for a very short moment. This happens only for the compiled .exe, not when running as Python package.
Do you experience the same issue? (Execute python build.py to generate the .exe, then start .\dist\normcap-v0.1.6.exe)

I think it's an upstream issue with notify-py which leverages a powershell command under the hood. I'm already investigating...

@ashishpatel1992
Copy link
Contributor

Hi @dynobo ,
I haven't reached till that step yet. Stuck with the binary generated.
Although successfully able to compile it. Log here: https://pastebin.com/MHXsQ7RY
The compiled binary was giving me the error:
image

So, I have manually placed python38.dll to rectify the issue.
But now there is another error pyi_rth__tkinter
image

I am not sure how I can fix this. Do you have any idea about this?

@dynobo
Copy link
Owner Author

dynobo commented Nov 2, 2020

Hi @ashishpatel1992,
Is your python version 3.8? I think pyinstaller doesn't yet support this... Could you try with 3.7.x?
Also make sure you are running the .exe in the dist/ folder, not in the build/ folder (this confused me in the beginning. It throws a similar error.)

In the meanwhile I filed an PR for the notification Package: ms7m/notify-py#18
We'll see if/when it get's accepted :-)

@dynobo
Copy link
Owner Author

dynobo commented Nov 2, 2020

Solve with release v0.1.6.
Thanks for you input, @ashishpatel1992 !

@dynobo dynobo closed this as completed Nov 2, 2020
@ashishpatel1992
Copy link
Contributor

Glad to know that issue is fixed. 🥇

@dynobo dynobo removed the in progress label Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog This issue is on the roadmap
Projects
None yet
Development

No branches or pull requests

2 participants