Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make subtitles button be a toggle #1001

Open
lollilol opened this issue Jul 14, 2023 · 1 comment
Open

make subtitles button be a toggle #1001

lollilol opened this issue Jul 14, 2023 · 1 comment
Labels
enhancement New feature or request ui-ux/user Problem with the UI/UX from an end user perspective

Comments

@lollilol
Copy link

Is your feature request related to a problem? Please describe.

When you click on the subtitles button, it asks you "on" or "off"

Describe the solution you'd like

it should be a toggle, like it is on youtube

Additional context

No response

@lollilol lollilol added the enhancement New feature or request label Jul 14, 2023
@dyc3 dyc3 added the ui-ux/user Problem with the UI/UX from an end user perspective label Jul 14, 2023
@dyc3
Copy link
Owner

dyc3 commented Jul 14, 2023

Yeah this would probably be better. The problem is that if the video provides multiple captions tracks, it's impossible to know how many tracks there are for all players (particularly the youtube player). The On/Off toggle becomes a language selector when the available tracks become known.

I suppose we could just have it enable whatever track comes first when you click the button, and then subsequent clicks you bring up a list of all the tracks and an off button. Tbh, I'm not sure if that's better or worse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ui-ux/user Problem with the UI/UX from an end user perspective
Projects
None yet
Development

No branches or pull requests

2 participants