fix: get the info about user only once as it is always the same

DXHeroes · Nov 22, 2019 · f54425d · f54425d
1 parent 2b67091
commit f54425d
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/src/services/bitbucket/BitbucketService.ts b/src/services/bitbucket/BitbucketService.ts
@@ -95,11 +95,10 @@ export class BitbucketService implements ICVSService {
 
     const response = <DeepRequired<Bitbucket.Response<Bitbucket.Schema.PaginatedPullrequests>>>await this.client.pullrequests.list(params);
     const url = 'www.bitbucket.org';
+    const ownerId = <string>(await this.client.users.get({ username: owner })).data.uuid;
+    const urlOwner = url.concat(`/${owner}`);
 
     const values = response.data.values.map(async (val) => {
-      const ownerId = <string>(
-        (await this.client.users.get({ username: `${val.destination.repository.full_name.split('/').shift()}` })).data.uuid
-      );
       return {
         user: {
           id: val.author.uuid,
@@ -122,9 +121,9 @@ export class BitbucketService implements ICVSService {
             name: val.destination.repository.name,
             id: val.destination.repository.uuid,
             owner: {
-              login: <string>val.destination.repository.full_name.split('/').shift(),
-              id: ownerId ? ownerId : 'undefined',
-              url: url.concat(`/${val.destination.repository.full_name.split('/').shift()}`),
+              login: owner,
+              id: ownerId,
+              url: urlOwner,
             },
           },
         },