fix: Logic with accessType and tests for private repo.

src/detectors/ScanningStrategyDetector.spec.ts

@@ -68,16 +68,9 @@ describe('ScanningStrategyDetector', () => {
         };
       });
 
-      const container = createTestContainer({ uri: '/local/path', auth: 'auth' });
+      const container = createTestContainer({ uri: '/local/path', auth: 'bad AT' });
 
-      const result = await container.scanningStrategyDetector.detect();
-
-      expect(result).toEqual({
-        accessType: AccessType.private,
-        localPath: '/local/path',
-        remoteUrl: repoPath,
-        serviceType: ServiceType.github,
-      });
+      await expect(container.scanningStrategyDetector.detect()).rejects.toThrow('bad credentials');
     });
 
     it('remote public GitHub', async () => {
@@ -106,14 +99,7 @@ describe('ScanningStrategyDetector', () => {
         .reply(404);
       const container = createTestContainer({ uri: repoPath, auth: 'bad AT' });
 
-      const result = await container.scanningStrategyDetector.detect();
-
-      expect(result).toEqual({
-        accessType: AccessType.private,
-        localPath: undefined,
-        remoteUrl: repoPath,
-        serviceType: ServiceType.github,
-      });
+      await expect(container.scanningStrategyDetector.detect()).rejects.toThrow('bad credentials');
     });
 
     it('remote public GitHub without protocol in the URL', async () => {

src/detectors/ScanningStrategyDetector.ts

@@ -26,6 +26,7 @@ export class ScanningStrategyDetector implements IDetector<string, ScanningStrat
     const path = ScanningStrategyDetectorUtils.normalizePath(this.argumentsProvider.uri);
 
     const inputType = this.determineInputType(path);
+
     // try to determine remote origin if input is local file system
     if (inputType === ServiceType.local) {
       remoteService = await this.determineRemote(path);
@@ -41,10 +42,6 @@ export class ScanningStrategyDetector implements IDetector<string, ScanningStrat
       accessType = await this.determineRemoteAccessType({ remoteUrl: path, serviceType });
     }
 
-    if (accessType === AccessType.private && this.argumentsProvider.auth === undefined) {
-      throw new Error('AT was not provided');
-    }
-
     return {
       serviceType,
       accessType,
@@ -78,10 +75,7 @@ export class ScanningStrategyDetector implements IDetector<string, ScanningStrat
       try {
         response = await this.gitHubClient.get(parsedUrl.owner, parsedUrl.name);
       } catch (error) {
-        if (error.status && error.status === 404) {
-          return AccessType.private;
-        }
-        throw error;
+        throw ErrorFactory.newInternalError('You passed bad credentials or non existing repo.');
       }
 
       if (response.status === 200) {