fix: add getRepoCommits() into interface,

fix: add return type
DXHeroes · Nov 27, 2019 · 8b544ef · 8b544ef
1 parent fba7af9
commit 8b544ef
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/src/services/bitbucket/BitbucketService.ts b/src/services/bitbucket/BitbucketService.ts
@@ -282,7 +282,7 @@ export class BitbucketService implements ICVSService {
     throw new Error('Method not implemented yet.');
   }
 
-  async getRepoCommits(owner: string, repo: string) {
+  async getRepoCommits(owner: string, repo: string): Promise<Paginated<Commit>> {
     throw new Error('Method not implemented yet.');
   }
 

diff --git a/src/services/git/GitHubService.ts b/src/services/git/GitHubService.ts
@@ -177,7 +177,7 @@ export class GitHubService implements ICVSService {
    *
    * Sha can be SHA or branch name.
    */
-  async getRepoCommits(owner: string, repo: string, sha?: string) {
+  async getRepoCommits(owner: string, repo: string, sha?: string): Promise<Paginated<Commit>> {
     let url = 'GET /repos/:owner/:repo/commits';
     if (sha !== undefined) {
       url = `${url}?state=${sha}`;

diff --git a/src/services/git/ICVSService.ts b/src/services/git/ICVSService.ts
@@ -12,6 +12,7 @@ export interface ICVSService {
   getPullRequestReviews(owner: string, repo: string, prNumber: number): Promise<Paginated<PullRequestReview>>;
   getPullRequestFiles(owner: string, repo: string, prNumber: number): Promise<Paginated<PullFiles>>;
   getPullRequest(owner: string, repo: string, prNumber: number): Promise<PullRequest>;
+  getRepoCommits(owner: string, repo: string, sha?: string): Promise<Paginated<Commit>>;
   getCommit(owner: string, repo: string, commitSha: string): Promise<Commit>;
   getContributors(owner: string, repo: string): Promise<Paginated<Contributor>>;
   getContributorsStats(owner: string, repo: string): Promise<Paginated<ContributorStats>>;