fix(core): exit after the printing the debug

src/index.ts

@@ -1,6 +1,6 @@
 import 'reflect-metadata';
 import { createRootContainer } from './inversify.config';
-import { Scanner } from './scanner/Scanner';
+import { Scanner, ScanResult } from './scanner/Scanner';
 import { Command, flags } from '@oclif/command';
 import cli from 'cli-ux';
 import { ServiceError } from './lib/errors';
@@ -52,8 +52,9 @@ class DXScannerCommand extends Command {
     const container = createRootContainer({ uri: scanPath, auth: authorization, json, fail });
     const scanner = container.get(Scanner);
 
+    let scanResult: ScanResult;
     try {
-      await scanner.scan();
+      scanResult = await scanner.scan();
     } catch (error) {
       if (error instanceof ServiceError) {
         ScanningStrategyDetectorUtils.isGitHubPath(scanPath)
@@ -65,7 +66,7 @@ class DXScannerCommand extends Command {
         const container = createRootContainer({ uri: scanPath, auth: authorization, json: json });
         const scanner = container.get(Scanner);
 
-        await scanner.scan();
+        scanResult = await scanner.scan();
       } else {
         throw error;
       }
@@ -76,6 +77,10 @@ class DXScannerCommand extends Command {
     const hrend = process.hrtime(hrstart);
 
     console.info('Scan duration %ds.', hrend[0]);
+
+    if (scanResult.shouldExitOnEnd) {
+      process.exit(1);
+    }
   }
 }
 

src/scanner/Scanner.ts

@@ -35,6 +35,7 @@ export class Scanner {
   private readonly practices: IPracticeWithMetadata[];
   private readonly argumentsProvider: ArgumentsProvider;
   private readonly scanDebug: debug.Debugger;
+  private shouldExitOnEnd = false;
 
   constructor(
     @inject(ScanningStrategyDetector) scanStrategyDetector: ScanningStrategyDetector,
@@ -52,7 +53,7 @@ export class Scanner {
     this.scanDebug = debug('scanner');
   }
 
-  async scan(): Promise<void> {
+  async scan(): Promise<ScanResult> {
     let scanStrategy = await this.scanStrategyDetector.detect();
     this.scanDebug(`Scan strategy: ${inspect(scanStrategy)}`);
     scanStrategy = await this.preprocessData(scanStrategy);
@@ -70,6 +71,8 @@ export class Scanner {
         projectComponents.length,
       )}; Practices: ${inspect(componentsWithPractices.length)}.`,
     );
+
+    return { shouldExitOnEnd: this.shouldExitOnEnd };
   }
 
   /**
@@ -182,7 +185,7 @@ export class Scanner {
 
     const notPracticingPracticesToFail = ScannerUtils.filterNotPracticingPracticesToFail(relevantPractices, this.argumentsProvider);
     if (notPracticingPracticesToFail.length > 0) {
-      process.exit(1);
+      this.shouldExitOnEnd = true;
     }
   }
 
@@ -259,3 +262,7 @@ export interface PracticeWithContext {
   evaluation: PracticeEvaluationResult;
   isOn: boolean;
 }
+
+export type ScanResult = {
+  shouldExitOnEnd: boolean;
+};