feat: change practice 'Update Dependencies' to 'Update Dependencies w…

…ith Major Level'

src/practices/JavaScript/DependenciesVersionPractice.ts

@@ -1,14 +1,13 @@
-import { PracticeImpact, PracticeEvaluationResult, ProgrammingLanguage } from '../../model';
+import { PracticeContext } from '../../contexts/practice/PracticeContext';
+import { evaluateBySemverLevel, SemverVersion } from '../../detectors/utils';
+import { PracticeEvaluationResult, PracticeImpact, ProgrammingLanguage } from '../../model';
 import { DxPractice } from '../DxPracticeDecorator';
 import { IPractice } from '../IPractice';
-import { PracticeContext } from '../../contexts/practice/PracticeContext';
-import _ from 'lodash';
-import ncu from 'npm-check-updates';
 
 @DxPractice({
-  id: 'LanguageIndependent.DependenciesVersion',
-  name: 'Update Dependencies',
-  impact: PracticeImpact.high,
+  id: 'LanguageIndependent.DependenciesVersionMajorLevel',
+  name: 'Update Dependencies with Major Level',
+  impact: PracticeImpact.small,
   suggestion: 'Keep the dependencies updated to eliminate security concerns and compatibility issues. Use, for example, Renovate Bot.',
   reportOnlyOnce: true,
   url: 'https://renovatebot.com/',
@@ -21,26 +20,6 @@ export class DependenciesVersionPractice implements IPractice {
   }
 
   async evaluate(ctx: PracticeContext): Promise<PracticeEvaluationResult> {
-    if (ctx.fileInspector === undefined || ctx.packageInspector === undefined) {
-      return PracticeEvaluationResult.unknown;
-    }
-
-    const pkgs = ctx.packageInspector.packages;
-    const fakePkgJson: { dependencies: { [key: string]: string } } = { dependencies: {} };
-
-    pkgs &&
-      pkgs.forEach((p) => {
-        fakePkgJson.dependencies[p.name] = p.requestedVersion.value;
-      });
-
-    const result = await ncu.run({
-      packageData: JSON.stringify(fakePkgJson),
-    });
-
-    if (_.keys(result).length === 0) {
-      return PracticeEvaluationResult.practicing;
-    }
-
-    return PracticeEvaluationResult.notPracticing;
+    return evaluateBySemverLevel(ctx, SemverVersion.major);
   }
 }