fix: return issue is as a string,

fix: name of pullRequestState and issueState

src/services/git/Git.ts

@@ -2,7 +2,7 @@ import { Repository } from '../../model';
 import { isArray } from 'util';
 import { inject, injectable } from 'inversify';
 import { ErrorFactory } from '../../lib/errors/ErrorFactory';
-import { GitHubPullRequestState } from './ICVSService';
+import { CVSPullRequestState } from './ICVSService';
 import * as nodePath from 'path';
 import { Metadata, MetadataType, IProjectFilesBrowserService } from '../model';
 import { Types } from '../../types';
@@ -115,7 +115,7 @@ export class Git implements IProjectFilesBrowserService {
 
   async getPullRequestCount(): Promise<number> {
     const params = GitServiceUtils.getOwnerAndRepoName(this.repository.url);
-    return this.service.getPullRequests(params.owner, params.repoName, { filter: { state: GitHubPullRequestState.all } }).then((r) => {
+    return this.service.getPullRequests(params.owner, params.repoName, { filter: { state: CVSPullRequestState.all } }).then((r) => {
       if (!r) {
         throw ErrorFactory.newInternalError('Could not get pull requests');
       }

src/services/git/GitHubService.spec.ts

@@ -22,7 +22,7 @@ import { getPullsFilesServiceResponse } from './__MOCKS__/gitHubServiceMockFolde
 import { getPullCommitsResponse } from './__MOCKS__/gitHubServiceMockFolder/getPullsCommitsResponse.mock';
 import { getPullCommitsServiceResponse } from './__MOCKS__/gitHubServiceMockFolder/getPullCommitsServiceResponse.mock';
 import { GitHubNock } from '../../../test/helpers/gitHubNock';
-import { GitHubPullRequestState } from './ICVSService';
+import { CVSPullRequestState } from './ICVSService';
 import { getRepoCommitsResponse } from './__MOCKS__/gitHubServiceMockFolder/getRepoCommitsResponse.mock';
 import { File } from './model';
 
@@ -70,7 +70,7 @@ describe('GitHub Service', () => {
         'open',
       );
 
-      const response = await service.getPullRequests('octocat', 'Hello-World', { filter: { state: GitHubPullRequestState.open } });
+      const response = await service.getPullRequests('octocat', 'Hello-World', { filter: { state: CVSPullRequestState.open } });
       expect(response.items.map((item) => item.state)).toMatchObject(['open']);
     });
 
@@ -80,7 +80,7 @@ describe('GitHub Service', () => {
         'closed',
       );
 
-      const response = await service.getPullRequests('octocat', 'Hello-World', { filter: { state: GitHubPullRequestState.closed } });
+      const response = await service.getPullRequests('octocat', 'Hello-World', { filter: { state: CVSPullRequestState.closed } });
       expect(response.items.map((item) => item.state)).toMatchObject(['closed']);
     });
 
@@ -93,7 +93,7 @@ describe('GitHub Service', () => {
         'all',
       );
 
-      const response = await service.getPullRequests('octocat', 'Hello-World', { filter: { state: GitHubPullRequestState.all } });
+      const response = await service.getPullRequests('octocat', 'Hello-World', { filter: { state: CVSPullRequestState.all } });
       expect(response.items.map((item) => item.state)).toMatchObject(['open', 'closed']);
     });
   });

src/services/git/GitHubService.ts

@@ -13,7 +13,7 @@ import {
   IssueComment,
   Symlink,
 } from './model';
-import { ICVSService, GitHubPullRequestState } from './ICVSService';
+import { ICVSService, CVSPullRequestState } from './ICVSService';
 import { Paginated } from '../../inspectors/common/Paginated';
 import {
   IssuesListForRepoResponseItem,
@@ -68,7 +68,7 @@ export class GitHubService implements ICVSService {
   async getPullRequests(
     owner: string,
     repo: string,
-    options?: ListGetterOptions<{ state?: GitHubPullRequestState }>,
+    options?: ListGetterOptions<{ state?: CVSPullRequestState }>,
   ): Promise<Paginated<PullRequest>> {
     let url = 'GET /repos/:owner/:repo/pulls';
     if (options !== undefined && options.filter !== undefined && options.filter.state !== undefined) {
@@ -326,7 +326,7 @@ export class GitHubService implements ICVSService {
       updatedAt: val.updated_at,
       closedAt: val.closed_at,
       state: val.state,
-      id: val.id,
+      id: val.id.toString(),
       pullRequestUrl: val.pull_request && val.pull_request.url,
     }));
     const pagination = this.getPagination(response.length);
@@ -342,7 +342,7 @@ export class GitHubService implements ICVSService {
     const response = await this.unwrap(this.client.issues.get({ owner, repo, issue_number: issueNumber }));
 
     return {
-      id: response.data.id,
+      id: response.data.id.toString(),
       user: {
         login: response.data.user.login,
         id: response.data.user.id.toString(),

src/services/git/ICVSService.ts

@@ -6,7 +6,7 @@ export interface ICVSService {
   getPullRequests(
     owner: string,
     repo: string,
-    options?: ListGetterOptions<{ state?: GitHubPullRequestState }>,
+    options?: ListGetterOptions<{ state?: CVSPullRequestState }>,
   ): Promise<Paginated<PullRequest>>;
   getPullRequestReviews(owner: string, repo: string, prNumber: number): Promise<Paginated<PullRequestReview>>;
   getPullRequestFiles(owner: string, repo: string, prNumber: number): Promise<Paginated<PullFiles>>;
@@ -19,13 +19,13 @@ export interface ICVSService {
   getRepoContent(owner: string, repo: string, path: string): Promise<File | Symlink | Directory | null>;
 }
 
-export enum GitHubPullRequestState {
+export enum CVSPullRequestState {
   open = 'open',
   closed = 'closed',
   all = 'all',
 }
 
-export enum GitHubIssueState {
+export enum CVSIssueState {
   open = 'open',
   closed = 'closed',
   all = 'all',

src/services/git/__MOCKS__/gitHubServiceMockFolder/getIssuesServiceResponse.mock.ts

@@ -9,7 +9,7 @@ export const getIssuesServiceResponse: Paginated<Issue> = {
       body: 'a',
       closedAt: null,
       createdAt: '2019-06-26T15:11:43Z',
-      id: 461030590,
+      id: "461030590",
       pullRequestUrl: 'https://api.github.com/repos/octocat/Hello-World/pulls/513',
       state: 'open',
       updatedAt: '2019-06-26T15:11:43Z',
@@ -20,7 +20,7 @@ export const getIssuesServiceResponse: Paginated<Issue> = {
       body: '',
       closedAt: null,
       createdAt: '2019-06-24T19:43:52Z',
-      id: 460062740,
+      id: "460062740",
       pullRequestUrl: 'https://api.github.com/repos/octocat/Hello-World/pulls/512',
       state: 'open',
       updatedAt: '2019-06-24T19:43:52Z',

src/services/git/model.ts

@@ -80,7 +80,7 @@ export type Directory = Array<RepoContent>;
 
 export interface Issue {
   user: UserInfo;
-  id: number | string;
+  id: string;
   url: string;
   body: string;
   createdAt: string;