fix: Allow user to add impact in object in dx config file

DXHeroes · Sep 19, 2019 · 22e1577 · 22e1577
1 parent 70f4c9c
commit 22e1577
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/scanner/Scanner.ts b/src/scanner/Scanner.ts
@@ -176,7 +176,14 @@ export class Scanner {
 
     const reportString = this.reporter.report(
       relevantPractices.map((p) => {
-        const impact = p.componentContext.configProvider.getOverridenPractice(p.practice.getMetadata().id);
+        const config = p.componentContext.configProvider.getOverridenPractice(p.practice.getMetadata().id);
+
+        let impact;
+        if (typeof config === 'string') {
+          impact = config;
+        } else if (config && 'impact' in config) {
+          impact = config.impact;
+        }
 
         return {
           practice: {

diff --git a/src/scanner/ScannerUtils.ts b/src/scanner/ScannerUtils.ts
@@ -60,7 +60,6 @@ export class ScannerUtils {
    */
   static isFulfilled(practice: IPracticeWithMetadata, evaluatedPractices: PracticeWithContext[]): boolean {
     const practiceMetadata = practice.getMetadata();
-    // console.log(practiceMetadata.name, 'name');
     if (!practiceMetadata.dependsOn) return true;
 
     for (const evaluation of _.keys(practiceMetadata.dependsOn)) {