feat: Detect parcticing/notPracticing based on date of commit and dat…

…e of PR minus 30 days
DXHeroes · Nov 20, 2019 · 1948193 · 1948193
1 parent 648f066
commit 1948193
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/practices/LanguageIndependent/DoesPullRequests.ts b/src/practices/LanguageIndependent/DoesPullRequests.ts
@@ -40,7 +40,12 @@ export class DoesPullRequests implements IPractice {
     const ownerAndRepoName = GitServiceUtils.getOwnerAndRepoName(repoName);
 
     const pullRequests = await ctx.collaborationInspector.getPullRequests(ownerAndRepoName.owner, ownerAndRepoName.repoName);
-    if (pullRequests.items.length > 0) {
+    const repoCommits = await ctx.collaborationInspector.getRepoCommits(ownerAndRepoName.owner, ownerAndRepoName.repoName);
+
+    const prDate = new Date(repoCommits.items[0].author.date).getTime();
+    const commitDate = new Date(pullRequests.items[0].createdAt).getTime();
+
+    if (prDate - 1000 * 60 * 60 * 24 * 30 < commitDate) {
       return PracticeEvaluationResult.practicing;
     }