fix: rebind IContentRepositoryBrowser in practice instead of binding …

…in inversify.config.ts
DXHeroes · Dec 9, 2019 · 1141cad · 1141cad
1 parent af50b8d
commit 1141cad
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 12 deletions.
diff --git a/src/inspectors/CollaborationInspector.spec.ts b/src/inspectors/CollaborationInspector.spec.ts
@@ -17,8 +17,7 @@ describe('Collaboration Inspector', () => {
   let containerCtx: TestContainerContext;
 
   beforeAll(async () => {
-    const args = { uri: 'https://github.com/octocat/Hello-World' };
-    containerCtx = createTestContainer(args);
+    containerCtx = createTestContainer();
     inspector = <CollaborationInspector>containerCtx.practiceContext.collaborationInspector;
   });
 

diff --git a/src/inspectors/IssueTrackingInspector.spec.ts b/src/inspectors/IssueTrackingInspector.spec.ts
@@ -16,8 +16,7 @@ describe('Issue Tracking Inspector', () => {
   let containerCtx: TestContainerContext;
 
   beforeAll(async () => {
-    const args = { uri: 'https://github.com/octocat/Hello-World' };
-    containerCtx = createTestContainer(args);
+    containerCtx = createTestContainer();
     inspector = <IssueTrackingInspector>containerCtx.practiceContext.issueTrackingInspector;
   });
 

diff --git a/src/inversify.config.ts b/src/inversify.config.ts
@@ -70,9 +70,7 @@ export const createTestContainer = (
 
   // FileSystemService as default ProjectBrowser
   container.bind(Types.IProjectFilesBrowser).toConstantValue(vfss);
-  args?.uri.includes('github')
-    ? container.bind(Types.IContentRepositoryBrowser).to(GitHubService)
-    : container.bind(Types.IContentRepositoryBrowser).to(BitbucketService);
+  container.bind(Types.IContentRepositoryBrowser).to(GitHubService);
   container.bind(Types.IFileInspector).to(FileInspector);
   container.bind(Types.IPackageInspector).to(JavaScriptPackageInspector);
   container.bind(Types.ICollaborationInspector).to(CollaborationInspector);

diff --git a/src/practices/LanguageIndependent/DoesPullRequests.spec.ts b/src/practices/LanguageIndependent/DoesPullRequests.spec.ts
@@ -15,8 +15,7 @@ describe('DoesPullRequests', () => {
   });
 
   beforeAll(() => {
-    const args = { uri: 'https://github.com/octocat/Hello-World' };
-    containerCtx = createTestContainer(args);
+    containerCtx = createTestContainer();
     containerCtx.container.bind('DoesPullRequests').to(DoesPullRequestsPractice);
     practice = containerCtx.container.get('DoesPullRequests');
   });

diff --git a/src/practices/LanguageIndependent/TimeToSolvePullRequestsPractice.spec.ts b/src/practices/LanguageIndependent/TimeToSolvePullRequestsPractice.spec.ts
@@ -3,9 +3,10 @@ import nock from 'nock';
 import { CollaborationInspector } from '../../inspectors';
 import { createTestContainer, TestContainerContext } from '../../inversify.config';
 import { PracticeEvaluationResult } from '../../model';
-import { BitbucketPullRequestState } from '../../services';
+import { BitbucketPullRequestState, BitbucketService } from '../../services';
 import { BitbucketNock } from '../../test/helpers/bitbucketNock';
 import { TimeToSolvePullRequestsPractice } from './TimeToSolvePullRequestsPractice';
+import { Types } from '../../types';
 
 describe('TimeToSolvePullRequestsPractice', () => {
   let practice: TimeToSolvePullRequestsPractice;
@@ -20,9 +21,9 @@ describe('TimeToSolvePullRequestsPractice', () => {
   });
 
   beforeAll(() => {
-    const args = { uri: 'https://bitbucket.org/pypy/pypy' };
-    containerCtx = createTestContainer(args);
+    containerCtx = createTestContainer();
     containerCtx.container.bind('TimeToSolvePractice').to(TimeToSolvePullRequestsPractice);
+    containerCtx.container.rebind(Types.IContentRepositoryBrowser).to(BitbucketService);
     practice = containerCtx.container.get('TimeToSolvePractice');
     mockCollaborationInspector = new MockedCollaborationInspector();
   });