Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max-height on autocomplete dropdown #250

Open
Jbarget opened this issue Sep 15, 2017 · 4 comments
Open

Max-height on autocomplete dropdown #250

Jbarget opened this issue Sep 15, 2017 · 4 comments
Labels

Comments

@Jbarget
Copy link
Member

Jbarget commented Sep 15, 2017

At the moment we have this:
screen shot 2017-09-15 at 17 00 51

would be good to limit the height of the dropdown

@Jbarget Jbarget added the bug label Sep 15, 2017
@ZooeyMiller
Copy link
Collaborator

That looks like the old autocomplete feature, try pulling master and seeing if it's ok now?

@Jbarget
Copy link
Member Author

Jbarget commented Sep 15, 2017

pulled down master and now:
screen shot 2017-09-15 at 17 54 41

@finnhodgkin
Copy link
Collaborator

@Jbarget I guess it must be an Opera problem? It's the progressively enhanced accessible autocomplete so if it doesn't work it displays a native select menu. Chrome and Firefox selects both look nicer than that... I don't know if there's anything we can do to improve how browsers choose to show select menus.

Here's the working dropdown in chrome:

working

@ZooeyMiller
Copy link
Collaborator

It looks okay on opera (linux) pre-progressive enhancement to me:
screenshot from 2017-09-18 11-13-30

(the same on Chrome and Firefox too)

Could it partly be the way that macOS displays select boxes? Is it the same on Safari/Chrome/Firefox? Will look into styling select elements though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants