Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check site accessibility #167

Open
1 task
Cleop opened this issue Jul 28, 2017 · 3 comments
Open
1 task

Check site accessibility #167

Cleop opened this issue Jul 28, 2017 · 3 comments

Comments

@Cleop
Copy link
Member

Cleop commented Jul 28, 2017

As a disabled site user
I want to be able to use the Tudo list site easily
So that I can navigate and contribute effectively to the help-wanted issues.

  • Check the accessibility of the site
@Cleop Cleop added this to the Elixir MVP milestone Jul 28, 2017
@Cleop Cleop added the PT25m label Jul 28, 2017
@ZooeyMiller
Copy link
Collaborator

ZooeyMiller commented Sep 11, 2017

I just ran pa11y on the site from my command line and got a lot of errors.

pa11y results

I think fixing the problems which are currently there are a blocker for #190 but I'll read through the errors to see how big the jobs will be.

EDIT: most of the errors seem to be about contrast ratios of text, though when looking by eye the contrast ratios don't seem bad at all...

@samhstn
Copy link
Member

samhstn commented Sep 11, 2017

If I remember correctly when @Danwhy and I used this, we decided to hide the notices (as they are mainly informational), warnings we viewed, but didn't necessarily fix them, but we addressed all errors and made errors these fail our pre-commit hook.

See here for our config: https://github.com/LDMW/app/blob/708478e05393d6ec13928bb9fc7eca1f97d585cf/package.json#L10

@ZooeyMiller
Copy link
Collaborator

Using the config @Shouston3 linked to we're reduced to only the errors, of which the majority (at a scan 46 of 48) are from:

  • Rummage creating 2 a tags when using a sort_link, one of which has no content, but a valid href. I can see no real solution for this apart from not using rummage.
  • Insufficient contrast ratios on the labels. In my experience, automated accessibility audits tend to overestimate how poor the contrast is when it comes to coloured backgrounds. Either we make the backgrounds of the image a lot paler, or we ignore it for now.

Not sure how to ameliorate these without some pretty big changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants