New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reductions on ArraySymbols do not handle empty and length 1 arrays #43

Closed

arcondello opened this issue Jul 4, 2024 · 1 comment · Fixed by #44

Labels

bug

Member

arcondello commented Jul 4, 2024

For example, currently

>>> model.constant([]).all()
...
ValueError: cannot do a reduction on an empty array with an operation that has no identity without supplying an initial value

but we'd like it to follow NumPy

>>> np.asarray([]).all()
True

arcondello added the bug label

This was referenced Jul 4, 2024

Refactor dwave.optimization.generators #42

Merged

Add identity value for ArraySymbol.all() #44

Merged

Member Author

arcondello commented Jul 4, 2024

Looks like it was only All that was missing the initial value. And length-1 works for all. #44 adds tests for the rest.

arcondello closed this as completed in #44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment