-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: extend workflow to include assets build #81
Conversation
Terraform plan for environment:
|
Terraform plan for account:
|
Terraform plan for environment:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved
* ci: extend workflow to include assets build * ci: always build assets to test * ci: fix `get-version` conditional logic * ci: switch to `npm install` * ci: add `setup-node` to asset build * ci: point dependency path to `package.json` * ci: list all assets afterwards * ci: add push to S3 step * fix(terraform): use a single asset bucket for envs * ci: fix OIDC role * ci: add `id-token` permissions to `cdn` job * fix: fix linting and CI warning * ci: remove debug `ls` * ci: add asset build to `cd.yaml` * ci: pass `assets_version` to Terraform * docs: tweak GitHub OIDC subject comment * ci: tweak logic to include assets in TF apply logic
Description
Add jobs to build/push assets to S3.
Before submitting (or marking as "ready for review")