Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: extend workflow to include assets build #81

Merged
merged 17 commits into from
Apr 25, 2024
Merged

Conversation

JoshuaLicense
Copy link
Contributor

@JoshuaLicense JoshuaLicense commented Apr 24, 2024

Description

Add jobs to build/push assets to S3.

Before submitting (or marking as "ready for review")

  • Does the pull request title follow the conventional commit specification?
  • Have you performed a self-review of the code
  • Have you have added tests that prove the fix or feature is effective and working
  • Did you make sure to update any documentation relating to this change?

@JoshuaLicense JoshuaLicense self-assigned this Apr 24, 2024
Copy link
Contributor

github-actions bot commented Apr 25, 2024

Terraform plan for environment: int

Commit: 3d56c0d

API version: be6a3c6
Selfserve version: be6a3c6
Internal version: be6a3c6

Plan summary

0 to add, 0 to change, 0 to destroy


Show full plan
No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

Copy link
Contributor

github-actions bot commented Apr 25, 2024

Terraform plan for account: nonprod

Commit: 3d56c0d

Plan summary

0 to add, 0 to change, 0 to destroy


Show full plan
No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

Copy link
Contributor

github-actions bot commented Apr 25, 2024

Terraform plan for environment: dev

Commit: 3d56c0d

API version: be6a3c6
Selfserve version: be6a3c6
Internal version: be6a3c6

Plan summary

0 to add, 1 to change, 0 to destroy

🔄 Updates

module.service.module.cloudfront.aws_cloudfront_distribution.this[0]

Show full plan
Note: Objects have changed outside of Terraform

Terraform detected the following changes made outside of Terraform since the
last "terraform apply" which may have affected this plan:

  # module.service.module.cloudfront.aws_cloudfront_distribution.this[0] has changed
  ~ resource "aws_cloudfront_distribution" "this" {
        id                              = "E3R9S2AKJG4ZTR"
      ~ status                          = "InProgress" -> "Deployed"
        tags                            = {}
        # (21 unchanged attributes hidden)

        # (6 unchanged blocks hidden)
    }


Unless you have made equivalent changes to your configuration, or ignored the
relevant attributes using ignore_changes, the following plan may include
actions to undo or respond to these changes.

─────────────────────────────────────────────────────────────────────────────

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # module.service.module.cloudfront.aws_cloudfront_distribution.this[0] will be updated in-place
  ~ resource "aws_cloudfront_distribution" "this" {
        id                              = "E3R9S2AKJG4ZTR"
        tags                            = {}
        # (22 unchanged attributes hidden)

      - origin {
          - connection_attempts      = 3 -> null
          - connection_timeout       = 10 -> null
          - domain_name              = "vol-app-assets.s3.eu-west-1.amazonaws.com" -> null
          - origin_access_control_id = "E1FW6X81UDPZAI" -> null
          - origin_id                = "s3_oac" -> null
          - origin_path              = "/test" -> null
        }
      + origin {
          + connection_attempts      = 3
          + connection_timeout       = 10
          + domain_name              = "vol-app-assets.s3.eu-west-1.amazonaws.com"
          + origin_access_control_id = "E1FW6X81UDPZAI"
          + origin_id                = "s3_oac"
          + origin_path              = "/9e5f568"
        }

        # (5 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

@JoshuaLicense JoshuaLicense marked this pull request as ready for review April 25, 2024 10:01
Copy link

@clorro clorro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

.github/workflows/ci.yaml Show resolved Hide resolved
@JoshuaLicense JoshuaLicense merged commit 29ba77a into main Apr 25, 2024
13 of 14 checks passed
@JoshuaLicense JoshuaLicense deleted the add-assets-workflow branch April 25, 2024 11:53
JoshuaLicense added a commit that referenced this pull request Jul 25, 2024
* ci: extend workflow to include assets build

* ci: always build assets to test

* ci: fix `get-version` conditional logic

* ci: switch to `npm install`

* ci: add `setup-node` to asset build

* ci: point dependency path to `package.json`

* ci: list all assets afterwards

* ci: add push to S3 step

* fix(terraform): use a single asset bucket for envs

* ci: fix OIDC role

* ci: add `id-token` permissions to `cdn` job

* fix: fix linting and CI warning

* ci: remove debug `ls`

* ci: add asset build to `cd.yaml`

* ci: pass `assets_version` to Terraform

* docs: tweak GitHub OIDC subject comment

* ci: tweak logic to include assets in TF apply logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants