Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set filter button priority to be rendered below select filters #339

Merged
merged 2 commits into from
Sep 19, 2024
Merged

fix: set filter button priority to be rendered below select filters #339

merged 2 commits into from
Sep 19, 2024

Conversation

fibble
Copy link
Contributor

@fibble fibble commented Sep 19, 2024

Description

Set priority on Filter button so it renders below select boxes

Related issue: VOL-5815

Before submitting (or marking as "ready for review")

  • Does the pull request title follow the conventional commit specification?
  • Have you performed a self-review of the code
  • Have you have added tests that prove the fix or feature is effective and working
  • Did you make sure to update any documentation relating to this change?

@fibble fibble requested review from ilindsay and a team as code owners September 19, 2024 14:19
@jerotire jerotire changed the title fix: set filter button priority to be rendered below select filters. fix: set filter button priority to be rendered below select filters Sep 19, 2024
jerotire
jerotire previously approved these changes Sep 19, 2024
View reviewed changes
@jerotire jerotire merged commit 6b62805 into main Sep 19, 2024
19 checks passed
@jerotire jerotire deleted the filter-button-above-filters-vol-5815 branch September 19, 2024 14:39
@github-actions github-actions bot mentioned this pull request Sep 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerotire jerotire jerotire approved these changes

@ilindsay ilindsay Awaiting requested review from ilindsay ilindsay is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fibble @jerotire