Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: local.php.dist api service mappings require full URLs #309

Merged
merged 1 commit into from
Sep 6, 2024
Merged

fix: local.php.dist api service mappings require full URLs #309

merged 1 commit into from
Sep 6, 2024

Conversation

jerotire
Copy link
Contributor

@jerotire jerotire commented Sep 5, 2024 •
edited
Loading

Description

API Service Mapping Endpoints require URLs to be defined containing the Scheme, Host and Trailing Slash (as per existing postcode endpoint).

Related issue: N/A

Before submitting (or marking as "ready for review")

  • Does the pull request title follow the conventional commit specification?
  • Have you performed a self-review of the code
  • Have you have added tests that prove the fix or feature is effective and working
  • Did you make sure to update any documentation relating to this change?

@jerotire jerotire requested review from ilindsay, fibble and a team as code owners September 5, 2024 15:28
@ilindsay ilindsay merged commit 7e0ad37 into main Sep 6, 2024
23 checks passed
@ilindsay ilindsay deleted the fix/local-dist-service-api-mappings branch September 6, 2024 11:09
@github-actions github-actions bot mentioned this pull request Sep 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fibble fibble fibble approved these changes

@ilindsay ilindsay ilindsay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jerotire @fibble @ilindsay