fix(terraform): add jobRoleArn to Batch containers

[JoshuaLicense]

Description

Adds a jobRoleArn for the application when calling AWS via—the SDK.
Update the CloudWatch log name to include environment.

[github-actions]

Terraform plan for environment: int

Commit: 8e9dc29

API version: c5ba4e9
Selfserve version: c5ba4e9
Internal version: c5ba4e9

Plan summary

0 to add, 0 to change, 0 to destroy

---

Show full plan

No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

[github-actions]

Terraform plan for environment: dev

Commit: 8e9dc29

API version: c5ba4e9
Selfserve version: c5ba4e9
Internal version: c5ba4e9

Plan summary

0 to add, 2 to change, 1 to destroy

🗑️ Deletes

module.service.aws_cloudwatch_log_group.this

🔄 Updates

module.service.module.batch.aws_batch_job_definition.this["process-queue"]
module.service.module.batch.aws_batch_job_queue.this["default"]

---

Show full plan

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place
-/+ destroy and then create replacement

Terraform will perform the following actions:

  # module.service.aws_cloudwatch_log_group.this must be replaced
-/+ resource "aws_cloudwatch_log_group" "this" {
      ~ arn               = "arn:aws:logs:eu-west-1:054614622558:log-group:/aws/batch" -> (known after apply)
      ~ id                = "/aws/batch" -> (known after apply)
      ~ log_group_class   = "STANDARD" -> (known after apply)
      ~ name              = "/aws/batch" -> "/aws/batch/vol-app-dev" # forces replacement
      + name_prefix       = (known after apply)
      - tags              = {} -> null
        # (4 unchanged attributes hidden)
    }

  # module.service.module.batch.aws_batch_job_definition.this["process-queue"] will be updated in-place
  ~ resource "aws_batch_job_definition" "this" {
      ~ arn                        = "arn:aws:batch:eu-west-1:054614622558:job-definition/vol-app-dev-process-queue:2" -> (known after apply)
      ~ container_properties       = jsonencode(
            {
              - command                      = [
                  - "/var/www/html/vendor/bin/laminas",
                  - "--container=/var/www/html/config/container-cli.php",
                  - "queue:process-queue",
                ]
              - environment                  = [
                  - {
                      - name  = "ENVIRONMENT_NAME"
                      - value = "dev"
                    },
                  - {
                      - name  = "APP_VERSION"
                      - value = "da12d1b"
                    },
                ]
              - executionRoleArn             = "arn:aws:iam::054614622558:role/vol-app-dev-api-service-20240418150301367500000003"
              - fargatePlatformConfiguration = {
                  - platformVersion = "LATEST"
                }
              - image                        = "054614622558.dkr.ecr.eu-west-1.amazonaws.com/vol-app/cli:da12d1b"
              - logConfiguration             = {
                  - logDriver     = "awslogs"
                  - options       = {
                      - awslogs-group         = "/aws/batch"
                      - awslogs-region        = "eu-west-1"
                      - awslogs-stream-prefix = "process-queue"
                    }
                  - secretOptions = []
                }
              - mountPoints                  = []
              - resourceRequirements         = [
                  - {
                      - type  = "VCPU"
                      - value = "1"
                    },
                  - {
                      - type  = "MEMORY"
                      - value = "2048"
                    },
                ]
              - runtimePlatform              = {
                  - cpuArchitecture       = "ARM64"
                  - operatingSystemFamily = "LINUX"
                }
              - secrets                      = []
              - ulimits                      = []
              - volumes                      = []
            }
        ) -> (known after apply)
        id                         = "arn:aws:batch:eu-west-1:054614622558:job-definition/vol-app-dev-process-queue:2"
        name                       = "vol-app-dev-process-queue"
      ~ revision                   = 2 -> (known after apply)
        tags                       = {}
      ~ tags_all                   = {
          + "Environment" = "dev"
          + "Repository"  = "https://github.com/dvsa/vol-app"
        }
        # (8 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # module.service.module.batch.aws_batch_job_queue.this["default"] will be updated in-place
  ~ resource "aws_batch_job_queue" "this" {
        id                    = "arn:aws:batch:eu-west-1:054614622558:job-queue/vol-app-dev-default"
        name                  = "vol-app-dev-default"
      + tags                  = {}
        # (6 unchanged attributes hidden)
    }

Plan: 1 to add, 2 to change, 1 to destroy.