From 407504a9d8fa15f6f035d0837578f567939b4d7e Mon Sep 17 00:00:00 2001
From: dvirtz <dvirtz@gmail.com>
Date: Sun, 10 Sep 2023 20:56:31 +0100
Subject: [PATCH] ci: update to node 18

disable caching due to
https://github.com/actions/setup-node/issues/712
---
 .github/workflows/main.yml | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index a953188..1281f8a 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -23,16 +23,11 @@ jobs:
         with:
           fetch-depth: 0 # for commit linting and semantic-release
           persist-credentials: false
-      - if: ${{ env.ACT }}
-        name: Hack container for local development
-        run: |
-            curl -fsSL https://deb.nodesource.com/setup_16.x | sudo -E bash -
-            sudo apt-get install -y nodejs
       - name: Install Node.js
         uses: actions/setup-node@v3
         with:
-          node-version: 16
-          cache: npm
+          # 18 doesn't work on windows: https://github.com/microsoft/vscode-test/issues/234
+          node-version: ${{ matrix.os == 'windows-latest' && '16' || '18' }}
       - uses: actions/setup-python@v4
         with:
           python-version: '3.10'
@@ -84,8 +79,7 @@ jobs:
       - name: Install Node.js
         uses: actions/setup-node@v3
         with:
-          node-version: 16
-          cache: npm
+          node-version: 18
       - uses: actions/setup-python@v4
         with:
           python-version: '3.10'