Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't save new file #35

Closed
HomenSimpsor opened this issue Nov 19, 2015 · 10 comments
Closed

Can't save new file #35

HomenSimpsor opened this issue Nov 19, 2015 · 10 comments

Comments

@HomenSimpsor
Copy link

Opening an already existing file allows me to File > Save just fine, but try to File > Save as a new file and it throws an error.

image

Whatever filename is provided, the error message makes it look like it's trying to save to a glob: filename.*.

Unsure how to check the version number, but I believe this is 0.1.8 I'm using. Windows 8.

@dvcrn
Copy link
Owner

dvcrn commented Nov 20, 2015

Hmm. I tried to reproduce this on my Mac but don't run into this error.

  1. Open MarkRight
  2. Type random stuff in
  3. Save
  4. File dialog pops up, after picking a file, saving works fine
  5. Close MarkRight (or keep it open)
  6. Open same file again
  7. Change text so that the * indicator appears at the top of the page
  8. Hit 'save as'
  9. File saves accordingly (and updates path in title)

@djungowski
Copy link

@dvcrn That is because this error only appears in Windows. I can confirm that this error happens on Win7 32Bit aswell as Win10 64 Bit

I suppose an easy fix would be to simply support only .md files as it always seems to try to add .* as file ending, which is not allowed in Windows.

@urmilparikh
Copy link

+1

I too face this issue in Windows.
Possible cause could be that Save as type is All Files (*.*), which may add .* at the end of file name.

@gauravmahto
Copy link

+1
I too face this issue.
On Win10_x64

@dvcrn dvcrn added the Windows label May 6, 2016
@dvcrn dvcrn mentioned this issue May 6, 2016
@dvcrn dvcrn mentioned this issue May 19, 2016
@dvcrn
Copy link
Owner

dvcrn commented May 20, 2016

can someone try one of these versions?

https://dl.dropboxusercontent.com/u/27953127/tmp/MarkRight_Windows32.exe
https://dl.dropboxusercontent.com/u/27953127/tmp/MarkRight_Windows64.exe

It would help a lot since I don't have a windows machine to confirm

@djungowski
Copy link

Works with the 32Bit Version

@urmilparikh
Copy link

Works with 64-bit version as well.

However, it still shows 'Electron' in Open-with menu and still does not open the file when double-clicked a file in Windows Explorer. May be, command-line arguments are ignore at some stage.

@dvcrn
Copy link
Owner

dvcrn commented May 20, 2016

Thanks for the feedback guys! Then I can finally get rid of this annoying bug 😊

@djungowski
Copy link

Btw. You might consider using one of the VMs provided at https://developer.microsoft.com/en-us/microsoft-edge/tools/vms/windows/ to test things on Windows

@dvcrn
Copy link
Owner

dvcrn commented Jun 28, 2016

@dvcrn dvcrn closed this as completed Jun 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants