From 82beae84a6527bd47e4d50b3134d4022af450ffe Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?K=C3=A9vin=20Dunglas?= Date: Wed, 10 Jul 2024 00:17:24 +0200 Subject: [PATCH] fix: musl crash using Go CL 600296 --- .github/workflows/docker.yaml | 2 +- alpine.Dockerfile | 23 +++++------------------ 2 files changed, 6 insertions(+), 19 deletions(-) diff --git a/.github/workflows/docker.yaml b/.github/workflows/docker.yaml index 22a5c4bf9..62cf6d640 100644 --- a/.github/workflows/docker.yaml +++ b/.github/workflows/docker.yaml @@ -207,7 +207,7 @@ jobs: run: | docker run --platform=${{ matrix.platform }} --rm \ "$(jq -r '."builder-${{ matrix.variant }}"."containerimage.config.digest"' <<< "${METADATA}")" \ - sh -c 'go test ${{ matrix.race }} -v ./... && cd caddy && go test ${{ matrix.race }} -v ./...' + sh -c 'gotip test ${{ matrix.race }} -v ./... && cd caddy && gotip test ${{ matrix.race }} -v ./...' env: METADATA: ${{ steps.build.outputs.metadata }} # Adapted from https://docs.docker.com/build/ci/github-actions/multi-platform/ diff --git a/alpine.Dockerfile b/alpine.Dockerfile index af0140bd5..d23590bac 100644 --- a/alpine.Dockerfile +++ b/alpine.Dockerfile @@ -67,33 +67,20 @@ RUN apk add --no-cache --virtual .build-deps \ readline-dev \ sqlite-dev \ upx \ - # Needed for the custom Go build + # Needed by gotip git \ bash -# FIXME: temporary workaround for https://github.com/golang/go/issues/68285 -WORKDIR / -RUN git clone https://go.googlesource.com/go goroot -WORKDIR /goroot -# Revert https://github.com/golang/go/commit/3560cf0afb3c29300a6c88ccd98256949ca7a6f6 to prevent the crash with musl -RUN git config --global user.email "build@example.com" && \ - git config --global user.name "Build" && \ - git checkout "$(go env GOVERSION)" && \ - git revert 3560cf0afb3c29300a6c88ccd98256949ca7a6f6 -WORKDIR /goroot/src -ENV GOHOSTARCH="$TARGETARCH" -RUN ./make.bash -ENV PATH="/goroot/bin:$PATH" -RUN go version +RUN GOBIN=/usr/local/go/bin go install golang.org/dl/gotip@latest && (yes || true) | gotip download 600296 WORKDIR /go/src/app COPY --link go.mod go.sum ./ -RUN go mod graph | awk '{if ($1 !~ "@") print $2}' | xargs go get +RUN gotip mod graph | awk '{if ($1 !~ "@") print $2}' | xargs gotip get WORKDIR /go/src/app/caddy COPY caddy/go.mod caddy/go.sum ./ -RUN go mod graph | awk '{if ($1 !~ "@") print $2}' | xargs go get +RUN gotip mod graph | awk '{if ($1 !~ "@") print $2}' | xargs gotip get WORKDIR /go/src/app COPY --link *.* ./ @@ -106,7 +93,7 @@ COPY --link testdata testdata ENV CGO_LDFLAGS="-lssl -lcrypto -lreadline -largon2 -lcurl -lonig -lz $PHP_LDFLAGS" CGO_CFLAGS="-DFRANKENPHP_VERSION=$FRANKENPHP_VERSION $PHP_CFLAGS" CGO_CPPFLAGS=$PHP_CPPFLAGS WORKDIR /go/src/app/caddy/frankenphp -RUN GOBIN=/usr/local/bin go install -ldflags "-w -s -extldflags '-Wl,-z,stack-size=0x80000' -X 'github.com/caddyserver/caddy/v2.CustomVersion=FrankenPHP $FRANKENPHP_VERSION PHP $PHP_VERSION Caddy'" && \ +RUN GOBIN=/usr/local/bin gotip install -ldflags "-w -s -extldflags '-Wl,-z,stack-size=0x80000' -X 'github.com/caddyserver/caddy/v2.CustomVersion=FrankenPHP $FRANKENPHP_VERSION PHP $PHP_VERSION Caddy'" && \ setcap cap_net_bind_service=+ep /usr/local/bin/frankenphp && \ upx --best /usr/local/bin/frankenphp && \ frankenphp version