Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui-components 전체 리팩토링 #289

Closed
43 of 46 tasks
jisungbin opened this issue Oct 17, 2022 · 0 comments
Closed
43 of 46 tasks

ui-components 전체 리팩토링 #289

jisungbin opened this issue Oct 17, 2022 · 0 comments
Assignees
@jisungbin
Labels
enhancement New features or improvements _giveup #400

Comments

@jisungbin
Copy link
Contributor

jisungbin commented Oct 17, 2022 •
edited
Loading

현재는 MVP 배포를 위해 컴포넌트 구현에만 초점을 둬서 최적화와 문서화, 테스트가 진행되지 않음
추후 리팩토링을 진행하면서 다 바로잡아야 함

UI Components

animation

  • QuackAnimatedContentTransform
  • AnimationSpec

border

  • QuackBorder

color

  • QuackColor

component

완료 기준: 밴치마크 작성, 스냅샷 테스트 작성, 문서화, 로직 개선, QuackSurface 사용
밴치마크와 테스트 작성은 우선순위 하향

  • internal
  • BottomNavigation
  • BottomSheet
  • button
  • card
  • divider: 무의미한 구현이라 제거
  • drawer
  • DropDown
  • GridLayout
  • label
  • selectableImage: image 패키지에 합체
  • surface
  • tab
  • tag
  • textarea
  • toggle
  • TopAppBar
  • typography
  • fab (TODO: 메뉴 부분에 커스텀 레이아웃 필요)
  • image (TODO: 가장 작은 DelectionImage 에 커스텀 레이아웃 필요)
  • textfield (TODO: QuackSearchTextField 에 커스텀 레이아웃 필요)

constant

  • size

icon

  • QuackIcon
  • QuackIcon - 리소스들 (아이콘 xml 파일)

modifier

  • clickable
  • draw

textstyle

  • QuackTextStyle

theme

  • QuackTheme

util

  • assert
  • detekt
  • DpSize
  • layout
  • optin
  • padding
  • runIf
  • string
@jisungbin jisungbin added bug Something isn't working ui-components labels Oct 17, 2022
@jisungbin jisungbin self-assigned this Oct 17, 2022
@jisungbin jisungbin pinned this issue Oct 17, 2022
@jisungbin jisungbin removed the bug Something isn't working label Oct 17, 2022
@jisungbin jisungbin added this to the quack-refactoring milestone Nov 9, 2022
@jisungbin jisungbin added the enhancement New features or improvements label Nov 9, 2022
@jisungbin jisungbin changed the title 전체 컴포넌트 리팩토링 프로젝트 전체 리팩토링 Nov 11, 2022
@jisungbin jisungbin mentioned this issue Nov 11, 2022
Merged
@jisungbin jisungbin added lint documentation Rebuild project website and removed bypass labels Nov 12, 2022
@jisungbin jisungbin linked a pull request Nov 18, 2022 that will close this issue
feat: ui-components 재구현 #365
Merged
@jisungbin jisungbin removed a link to a pull request Nov 18, 2022
feat: ui-components 재구현 #365
Merged
@jisungbin jisungbin changed the title 프로젝트 전체 리팩토링 ui-components 전체 리팩토링 Nov 30, 2022
@jisungbin jisungbin removed lint documentation Rebuild project website labels Nov 30, 2022
@jisungbin jisungbin removed the test label Nov 30, 2022
@jisungbin jisungbin unpinned this issue Dec 3, 2022
@jisungbin jisungbin closed this as not planned Won't fix, can't repro, duplicate, stale Dec 22, 2022
@jisungbin jisungbin added the _giveup #400 label Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jisungbin jisungbin

Labels
enhancement New features or improvements _giveup #400
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jisungbin