Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logic for version bumping in CD #196

Closed
Tracked by #259
jisungbin opened this issue Oct 3, 2022 · 1 comment
Closed
Tracked by #259

Improve logic for version bumping in CD #196

jisungbin opened this issue Oct 3, 2022 · 1 comment
Assignees
Labels
enhancement New features or improvements help wanted Extra attention is needed

Comments

@jisungbin
Copy link
Contributor

jisungbin commented Oct 3, 2022

Currently, all cases are hard-coded, so maintenance is not easy.

# 🤯
# https://github.com/duckie-team/duckie-quack-quack/blob/develop/.github/workflows/artifact-publish.yml

 - name: Bump artifact version (type_Major, target_LintQuack)
   if: ${{
     contains(github.event.pull_request.labels.*.name, 'bump_major') &&
     contains(github.event.pull_request.labels.*.name, 'target_lint-quack')
     }}
   run: ./gradlew bumpVersion --scan -Ptype="Major" -Ptarget="LintQuack"

 - name: Bump artifact version (type_Major, target_LintCompose)
   if: ${{
     contains(github.event.pull_request.labels.*.name, 'bump_major') &&
     contains(github.event.pull_request.labels.*.name, 'target_lint-compose')
     }}
   run: ./gradlew bumpVersion --scan -Ptype="Major" -Ptarget="LintCompose"

 - name: Bump artifact version (type_Major, target_UiComponents)
   if: ${{
     contains(github.event.pull_request.labels.*.name, 'bump_major') &&
     contains(github.event.pull_request.labels.*.name, 'target_ui-components')
     }}
   run: ./gradlew bumpVersion --scan -Ptype="Major" -Ptarget="UiComponents"

 - name: Bump artifact version (type_Minor, target_LintCore)
   if: ${{
     contains(github.event.pull_request.labels.*.name, 'bump_minor') &&
     contains(github.event.pull_request.labels.*.name, 'target_lint-core')
     }}
   run: ./gradlew bumpVersion --scan -Ptype="Minor" -Ptarget="LintCore"

# ...

We need to find a way to implement it by eliminating the repetitive structure.

--

Reference

conference-app-2022/CommentPR.yml 를 보면 자바스크립트를 사용하고 있다.

image

나도 이런식으로 해결할 수 있지 않을까?

@jisungbin jisungbin added enhancement New features or improvements help wanted Extra attention is needed labels Oct 3, 2022
@jisungbin jisungbin self-assigned this Oct 3, 2022
@jisungbin jisungbin changed the title Improved logic for version bumping in CD Improve logic for version bumping in CD Oct 3, 2022
@jisungbin jisungbin pinned this issue Oct 3, 2022
@jisungbin jisungbin mentioned this issue Oct 14, 2022
13 tasks
@jisungbin jisungbin unpinned this issue Oct 14, 2022
@jisungbin
Copy link
Contributor Author

DONE

#310

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or improvements help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant