Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Clibsodium.xcframework to fix Xcode Previews #21

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Update Clibsodium.xcframework to fix Xcode Previews #21

merged 1 commit into from
Feb 25, 2025

Conversation

mallexxx
Copy link
Contributor

@mallexxx mallexxx commented Feb 21, 2025 •
edited
Loading

Task URL: https://app.asana.com/0/1201037661562251/1209464112525120
macOS PR: duckduckgo/apple-browsers#76

Description:

Steps to test:

  • Validate sync_crypto lib works as intended (sync works)
  • Turn on Editor -> Canvas -> Use legacy previews
  • Clean-build for testing
  • Validate Xcode previews works

@mallexxx mallexxx requested a review from ayoy February 21, 2025 14:19
@mallexxx mallexxx mentioned this pull request Feb 21, 2025
Merged
1 task
ayoy
ayoy approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

@mallexxx mallexxx merged commit 4e383fa into main Feb 25, 2025
2 checks passed
mallexxx added a commit to duckduckgo/apple-browsers that referenced this pull request Feb 25, 2025
@mallexxx
Update Clibsodium.xcframework to fix Xcode Previews (#76)
d7ce68a 
Task/Issue URL:
https://app.asana.com/0/1201037661562251/1209464112525120
sync_crypto PR: duckduckgo/sync_crypto#21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayoy ayoy ayoy approved these changes

Assignees

@mallexxx mallexxx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mallexxx @ayoy