Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rchk errors #635

Closed
3 tasks done
krlmlr opened this issue Dec 7, 2024 · 2 comments
Closed
3 tasks done

Fix rchk errors #635

krlmlr opened this issue Dec 7, 2024 · 2 comments
Milestone

Comments

@krlmlr
Copy link
Collaborator

krlmlr commented Dec 7, 2024

  • Bump vendored cpp11 to 0.5.1, restoring our patches
  • Fix other rchk issues
  • Fix uninitialized warning
@krlmlr krlmlr added this to the 1.1.3-1 milestone Dec 7, 2024
@krlmlr
Copy link
Collaborator Author

krlmlr commented Dec 7, 2024

Current results:

Function duckdb::RApiTypes::DetectRType(SEXPREC*, bool)
  [UP] unprotected variable names while calling allocating function duckdb::RApiTypes::DetectRType(SEXPREC*, bool) /rchk/packages/build/o2sCSHZS/duckdb/src/types.cpp:159

Function rapi_bind(cpp11::external_pointer<duckdb::RStatement, &(void cpp11::default_deleter<duckdb::RStatement>(duckdb::RStatement*))>, cpp11::r_vector<SEXPREC*>, bool, bool)
  [UP] calling allocating function cpp11::writable::r_vector<SEXPREC*>::push_back(SEXPREC*) with argument allocated using rapi_execute(cpp11::external_pointer<duckdb::RStatement, &(void cpp11::default_deleter<duckdb::RStatement>(duckdb::RStatement*))>, bool, bool) /rchk/packages/build/o2sCSHZS/duckdb/src/statement.cpp:215

Function rapi_execute(cpp11::external_pointer<duckdb::RStatement, &(void cpp11::default_deleter<duckdb::RStatement>(duckdb::RStatement*))>, bool, bool)
  [UP] unprotected variable <unnamed var:   %4 = alloca %struct.SEXPREC*, align 8> while calling allocating function duckdb::unique_ptr<duckdb::QueryResult, std::__1::default_delete<duckdb::QueryResult>, true>::~unique_ptr() /rchk/packages/build/o2sCSHZS/duckdb/src/statement.cpp:382

@krlmlr
Copy link
Collaborator Author

krlmlr commented Dec 8, 2024

Done now.

@krlmlr krlmlr closed this as completed Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant