Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Did rlang become 'required' ? #601

Closed
eddelbuettel opened this issue Nov 22, 2024 · 1 comment
Closed

Did rlang become 'required' ? #601

eddelbuettel opened this issue Nov 22, 2024 · 1 comment
Milestone

Comments

@eddelbuettel
Copy link

eddelbuettel commented Nov 22, 2024

I noticed in a container that duckdb and DBI alone lead to an error -- rlang is missing.

On my normal machine, loading duckdb also loads rlang. But rlang is only a 'Suggests:' for both duckdb and DBI.

$ R

R version 4.4.2 (2024-10-31) -- "Pile of Leaves"
Copyright (C) 2024 The R Foundation for Statistical Computing
Platform: x86_64-pc-linux-gnu

R is free software and comes with ABSOLUTELY NO WARRANTY.
You are welcome to redistribute it under certain conditions.
Type 'license()' or 'licence()' for distribution details.

  Natural language support but running in an English locale

R is a collaborative project with many contributors.
Type 'contributors()' for more information and
'citation()' on how to cite R or R packages in publications.

Type 'demo()' for some demos, 'help()' for on-line help, or
'help.start()' for an HTML browser interface to help.
Type 'q()' to quit R.

> packageVersion("duckdb")
[1] ‘1.1.3’
> library(duckdb)
Loading required package: DBI
Loading required namespace: rlang
> 

If rlang gets autoloaded, and if it leads to a failure of instantiation when not present this appears to be more than a Suggests. Currently it is only a Suggests meaning the generated binary package does not depend on it, and the load fails:

$ docker run --rm -ti rocker/r2u:24.04 bash
root@1c98fa4ef0c8:/# Rscript -e 'install.packages("duckdb")' 2>&1 >/dev/null    # only co-installs DBI
root@1c98fa4ef0c8:/# R -q
> library(duckdb)
Loading required package: DBI
Loading required namespace: rlang
Failed with error:  ‘there is no package called ‘rlang’’
> 

PS Once one co-installs rlang all is well but then it should probably be at an Imports: level. A demo is here.

@krlmlr krlmlr added this to the 1.1.3-1 milestone Dec 4, 2024
@krlmlr
Copy link
Collaborator

krlmlr commented Dec 4, 2024

Fixed in 76bc023, thanks for the report.

@krlmlr krlmlr closed this as completed Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants