Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.10.7 breaks semver compatibility #84

Closed
RReverser opened this issue Jan 26, 2017 · 7 comments
Closed

Release 0.10.7 breaks semver compatibility #84

RReverser opened this issue Jan 26, 2017 · 7 comments
Labels

Comments

@RReverser
Copy link

Copying comment from #66:

@dtolnay Looks like you released it in 0.10.7 because @SimonSapin bumped version as part of his commit 07c7341 and thus broke semver - our build started failing with Use of undeclared type or module `BlockCheckMode` when Cargo started auto-pulling 0.10.7 instead of 0.10.6 :(

Maybe it's worth to unpublish release from Cargo? (I'm pretty sure we're not the only one whose build was broken)

@SimonSapin
Copy link
Contributor

Ah, this is my mistake. I branched my PR #83 from 881a5ef "Merge tag 0.10.6 into master", but I should have used 66a31d6 (tag: 0.10.6) "Release 0.10.6" instead. The former probably includes breaking changes from another branch.

I think 0.10.7 should be yanked from crates.io. @dtolnay, I’d appreciate if you could also make 0.10.8 with the unicode-xid upgrade from the correct base. I can provide a PR if you’d like, but since it’s a small change it might be easier to do it yourself?

@SimonSapin
Copy link
Contributor

@RReverser In the meantime, I think cargo update -p syn --precise 0.10.6 should fix your build.

@RReverser
Copy link
Author

@SimonSapin Not on Travis (unless we commit Cargo.lock too which is likely not what we want to do at the moment; alternatively could add this command to .travis.yml but then it seems better and more reliable to just yank this version).

@SimonSapin
Copy link
Contributor

Yes, this version should be yanked. This was just an attempt to unblock you until dtolnay can get around to doing it.

@RReverser
Copy link
Author

@SimonSapin Yeah, appreciate that.

@dtolnay
Copy link
Owner

dtolnay commented Jan 26, 2017

I yanked 0.10.7 and published 0.10.8 for @SimonSapin based on the correct commit. Really sorry about the break here.

@dtolnay dtolnay closed this as completed Jan 26, 2017
@dtolnay dtolnay added the bug label Jan 26, 2017
@RReverser
Copy link
Author

@dtolnay All good, thanks for the fast turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants