-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.10.7 breaks semver compatibility #84
Comments
Ah, this is my mistake. I branched my PR #83 from 881a5ef "Merge tag 0.10.6 into master", but I should have used 66a31d6 (tag: 0.10.6) "Release 0.10.6" instead. The former probably includes breaking changes from another branch. I think 0.10.7 should be yanked from crates.io. @dtolnay, I’d appreciate if you could also make 0.10.8 with the unicode-xid upgrade from the correct base. I can provide a PR if you’d like, but since it’s a small change it might be easier to do it yourself? |
@RReverser In the meantime, I think |
@SimonSapin Not on Travis (unless we commit |
Yes, this version should be yanked. This was just an attempt to unblock you until dtolnay can get around to doing it. |
@SimonSapin Yeah, appreciate that. |
I yanked 0.10.7 and published 0.10.8 for @SimonSapin based on the correct commit. Really sorry about the break here. |
@dtolnay All good, thanks for the fast turnaround! |
Copying comment from #66:
Maybe it's worth to unpublish release from Cargo? (I'm pretty sure we're not the only one whose build was broken)
The text was updated successfully, but these errors were encountered: