Skip to content
This repository has been archived by the owner on Mar 25, 2024. It is now read-only.

Support i128 and u128 #108

Closed
asomers opened this issue Oct 11, 2018 · 2 comments
Closed

Support i128 and u128 #108

asomers opened this issue Oct 11, 2018 · 2 comments

Comments

@asomers
Copy link
Contributor

asomers commented Oct 11, 2018

It would be great if serde_yaml could support u128 and i128. I'm working on a PR and I've got it mostly working. However, the code would be much simpler if it didn't have to support compiler versions < 1.26.0. Are you ok with abandoning old compilers? It's not a blocker if you aren't, but it does complicate things.

@dtolnay
Copy link
Owner

dtolnay commented Oct 11, 2018

Thanks for the upcoming PR! I would like to continue to support the same range of compiler versions.

@asomers
Copy link
Contributor Author

asomers commented Oct 11, 2018

Ok. In that case i128 support will be contingent on the consumer using a newer compiler and gated by a feature flag, just like in the bincode crate.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants