Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove impl Default for Span #48

Closed
dtolnay opened this issue Jan 6, 2018 · 1 comment
Closed

Remove impl Default for Span #48

dtolnay opened this issue Jan 6, 2018 · 1 comment
Assignees
@dtolnay
Milestone
0.2

Comments

@dtolnay
Copy link
Owner

dtolnay commented Jan 6, 2018

This was removed upstream in rust-lang/rust#45999. As discussed in rust-lang/rust#45934 (comment), there isn't really anything more "default" about def_site over call_site.

Worth changing before the syn 0.12 release before more people start banging on this stuff?
@alexcrichton
Copy link
Contributor

I originally just switched it over to avoid the breaking change, but syn is looking so polished nowadays I'd hate for this be a blemish! I'm game for making an 0.2 release with this change.

@dtolnay dtolnay added this to the 0.2 milestone Jan 6, 2018
@dtolnay dtolnay self-assigned this Jan 6, 2018
@dtolnay dtolnay mentioned this issue Jan 8, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dtolnay dtolnay

Labels
None yet
Projects
None yet
Milestone
0.2
Development

No branches or pull requests
2 participants
@alexcrichton @dtolnay