-
-
Notifications
You must be signed in to change notification settings - Fork 5
m! macro does not work with new ( 1.30.0 ) stable rusts #[macro_export(local_inner_macros)]
#16
Comments
Thanks, I would accept a PR to make mashup work with new style macro imports. |
I'm a little fuzzy on proc_macro_hack and proc_macro2 and if they are even needed anymore but I'm getting stuck on what scope to fit the exported substitution ( ex m! ) macros into. I tried both |
It looks like proc macro2 was a shim to get what was released in 1.30 working on stable before it was stable https://github.com/alexcrichton/proc-macro2/blob/master/README.md. does that mean this crate no longer needs it? |
@dtolnay I was going to try to take another take on this this week. Let me know if you can provide any context on the questions above. That may help save some time. |
I'm going to start an separate experiment to see if I can get away from the proc_macro2 dependency |
I learned after see travis errors in the Thoughts on removing support for older versions @dtolnay ? |
I also just noticed the no_raw_identifiers cfg settings. These are also now stabilized in 1.30.0 |
Closing because I don't plan to take a fix for this, people targeting newer toolchains should be using https://github.com/dtolnay/paste. |
a new feature stabilized in rust ( release notes here ) that allows macro authors to have rust "re-export" macros they depend on. I use my own macros which depend on
mashup!
and have tested this feature but it seems ( at least in doc tests ) that rust is not able to resolve them!
macro potentially because this is edgecasey and maybe not supported as I think mashup is a macro that produces a macro.I'm not sure if its a bug or a feature yet but I wanted to get it on your radar.
The text was updated successfully, but these errors were encountered: