Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TCStat config options and wrappers to filter data by excluding strings. #857

Closed
20 tasks done
JohnHalleyGotway opened this issue Mar 27, 2021 · 0 comments · Fixed by #862
Closed
20 tasks done
Assignees
Labels
component: python wrapper METplus: Configuration priority: medium Medium Priority requestor: DTC/AF V&V Air Force Verification and Validation Project type: enhancement Improve something that it is currently doing
Milestone

Comments

@JohnHalleyGotway
Copy link
Collaborator

JohnHalleyGotway commented Mar 27, 2021

Describe the Enhancement

The issue dtcenter/MET#1733 makes the following changes to MET:

  • Add TC-Stat configuration file options: column_str_exc_name, column_str_exc_val, init_str_exc_name, init_str_exc_val
  • Add TC-Stat job command options: -column_str_exc, -init_str_exc
  • Add Stat-Analysis job command options: -column_str_exc
    Please see the changed files here: https://github.com/dtcenter/MET/pull/1734/files

This task is to update METplus to accommodate these changes. Those changes may include changes to the wrapped TC-Stat config file and the python wrappers themselves.

Time Estimate

4 hours.

Sub-Issues

Consider breaking the enhancement down into sub-issues.
No sub-issues required.

Relevant Deadlines

METplus 4.0.0

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required: George
  • Select scientist(s) or no scientist required: no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Review projects and select relevant Repository and Organization ones or add "alert:NEED PROJECT ASSIGNMENT" label
  • Select milestone to next major version milestone or "Future Versions"

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s), Project(s), Milestone, and Linked issues
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added type: enhancement Improve something that it is currently doing component: python wrapper component: use case configuration priority: medium Medium Priority requestor: DTC/AF V&V Air Force Verification and Validation Project labels Mar 27, 2021
@JohnHalleyGotway JohnHalleyGotway added this to the METplus-4.0.0 milestone Mar 27, 2021
@JohnHalleyGotway JohnHalleyGotway changed the title Update METplus config options and wrappers for dtcenter/MET#1733 Update METplus config options and wrappers to filter data by excluding strings. Mar 27, 2021
@georgemccabe georgemccabe linked a pull request Mar 30, 2021 that will close this issue
11 tasks
@georgemccabe georgemccabe linked a pull request Mar 31, 2021 that will close this issue
11 tasks
@georgemccabe georgemccabe changed the title Update METplus config options and wrappers to filter data by excluding strings. Update TCStat config options and wrappers to filter data by excluding strings. Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: python wrapper METplus: Configuration priority: medium Medium Priority requestor: DTC/AF V&V Air Force Verification and Validation Project type: enhancement Improve something that it is currently doing
Projects
None yet
3 participants