Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Fix inconsistent Weather Regime classification numbers when the forecast is reordered #1553

Closed
23 tasks
CPKalb opened this issue Apr 5, 2022 · 0 comments · Fixed by #1568
Closed
23 tasks
Assignees
Labels
alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle type: bug Fix something that is not working

Comments

@CPKalb
Copy link
Contributor

CPKalb commented Apr 5, 2022

Replace italics below with details for this issue.

Describe the Problem

The weather regime classification is performed separately on the model and observations. Both are ordered by frequency (the most frequent regime listed first). Because of this, sometimes the regime numbers don't match (i.e. regime 1 in the observation may have the same weather pattern as regime 2 in the model or something similar). Reordering is currently done after the classification text file is written but before the plots, which means the numbers are inconsistent between the plots and files. This reordering needs to happen before the text file is written. This reordering needed to be moved from the Kmeans program in METcalcpy to a separate program, and then the program needs to be called at a different time from METplus

Expected Behavior

Reordering needs to happen before the text file is written

Environment

Describe your runtime environment:
*1. linux
2. OS: (e.g. RedHat Linux, MacOS)
*3. python 3.7.9

To Reproduce

Run the weather regime use case. The case runs successfully but the output is inconsistent

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

2793541

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Organization level Project for support of the current coordinated release
  • Select Repository level Project for development toward the next official release or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next bugfix version

Define Related Issue(s)

Consider the impact to the other METplus components.

Bugfix Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of main_<Version>.
    Branch name: bugfix_<Issue Number>_main_<Version>_<Description>
  • Fix the bug and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • Push local changes to GitHub.
  • Submit a pull request to merge into main_<Version>.
    Pull request: bugfix <Issue Number> main_<Version> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Organization level software support Project for the current coordinated release
    Select: Milestone as the next bugfix version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Complete the steps above to fix the bug on the develop branch.
    Branch name: bugfix_<Issue Number>_develop_<Description>
    Pull request: bugfix <Issue Number> develop <Description>
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Close this issue.
@CPKalb CPKalb added type: bug Fix something that is not working alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Apr 5, 2022
@CPKalb CPKalb self-assigned this Apr 5, 2022
@CPKalb CPKalb removed alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED ACCOUNT KEY Need to assign an account key to this issue labels Apr 12, 2022
@CPKalb CPKalb linked a pull request Apr 12, 2022 that will close this issue
14 tasks
@georgemccabe georgemccabe added this to the METplus-4.1.1 Bugfix milestone Apr 20, 2022
@georgemccabe georgemccabe changed the title Weather Regime classification numbers are inconsistent when the forecast is reordered Bugfix: Fix inconsistent Weather Regime classification numbers when the forecast is reordered Apr 20, 2022
Repository owner moved this from To do to Done in Coordinated METplus-4.1 Support Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle type: bug Fix something that is not working
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants