Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance TC-Pairs wrapper to make valid_inc, valid_exc, and write_valid configurable options. #1069

Closed
8 of 20 tasks
JohnHalleyGotway opened this issue Aug 5, 2021 · 1 comment · Fixed by #1122
Closed
8 of 20 tasks
Assignees
Labels
METplus: Configuration reporting: DTC NOAA R2O NOAA Research to Operations DTC Project requestor: NOAA/GSL NOAA Global Systems Laboratory required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: enhancement Improve something that it is currently doing
Milestone

Comments

@JohnHalleyGotway
Copy link
Collaborator

Describe the Enhancement

dtcenter/MET#1870 adds 3 new configurable options for TC-Pairs. This task is to enhance the METplus TC-Pairs wrapper to make those options configurable:

valid_inc   = [];
valid_exc   = [];
write_valid = [];

All 3 are arrays of strings that are empty be default. The can be filled with a comma-separated list of double-quoted string in "YYYYMMDD[_HH[MMSS]]" format. They configuration of them is exactly the same as the existing init_inc and init_exc options.

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.

Sub-Issues

Consider breaking the enhancement down into sub-issues.
No sub-issues needed.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

2792541 (copied from dtcenter/MET#1870)

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required: George
  • Select scientist(s) or no scientist required: Molly Smith

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

Assigned to the beta2 cycle, but this can be moved to beta3 if needed.

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added type: enhancement Improve something that it is currently doing requestor: NOAA/GSL NOAA Global Systems Laboratory reporting: DTC NOAA R2O NOAA Research to Operations DTC Project required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone METplus: Configuration labels Aug 5, 2021
@JohnHalleyGotway JohnHalleyGotway added this to the METplus-4.1.0 milestone Aug 5, 2021
@mollybsmith-noaa
Copy link
Contributor

I'll test on Jet with my realtime data once this issue is completed.

@JohnHalleyGotway JohnHalleyGotway added required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone and removed required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project labels Aug 18, 2021
@georgemccabe georgemccabe linked a pull request Aug 30, 2021 that will close this issue
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
METplus: Configuration reporting: DTC NOAA R2O NOAA Research to Operations DTC Project requestor: NOAA/GSL NOAA Global Systems Laboratory required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: enhancement Improve something that it is currently doing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants