Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VCRURLConnection doesn’t consider request headers and body #21

Open
0xced opened this issue Mar 6, 2014 · 1 comment
Open

VCRURLConnection doesn’t consider request headers and body #21

0xced opened this issue Mar 6, 2014 · 1 comment

Comments

@0xced
Copy link
Contributor

0xced commented Mar 6, 2014

VCRURLConnection doesn’t properly record requests if they have the same method and same URL but different headers and/or body. This is obvious when looking at the source code since VCRRequestKey is based on the URI and method properties only.

An example where this behavior becomes problematic is when using the Range header. Say you first ask for range 0-123 then you ask for range 0-12345. The second request will never be recorded because it’s considered equal to the first one since it has the same URL and same method.

I plan to work on this issue but before I start I’d like to know what’s the status of #16 as these issues are slightly related.

@dstnbrkr
Copy link
Owner

Thanks @0xced. Agree that VCRRequestKey should be expanded to differentiate between these requests.

I believe this work and #16 can move forward independently. This work makes VCRRequestKey a more precise mapping to a single recording while #16 maps a single VCRRequestKey to multiple recordings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants