-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more macro guarding for Windows #44
Comments
Note: I think that my original code was based on https://stackoverflow.com/q/2989810/5207081 |
Note 2: The current active documentation from Microsoft still specifies that
Reference: https://learn.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-170 The current code conforms completely to the stack. Unless the current state of the code is in some way broken, I don't really see a reason to update it? |
To be honest, I myself have not yet figured out this issue.
Seems, Maybe other macros useful for embedded windows targets) |
That is an interesting point you bring up. I have not heard of any users (yet) that use this library on embedded Windows platforms. If so, please reach out. :) The way I see it right now is, I would happily add more guarding if it fixes an issue. However, I want to be able to test that it does actually fix an issue. I would rather not copy-paste code from another library without knowing why it is there. Is it okay if I close this issue? If, in the future, we find a configuration on which the current header is broken, we can add the extra header. |
There are another point. Could you test another compilers: for example some of them - mingw, Borland C++, Intel C++, Embarcadero C++ Builder, Clang, TinyC compiler, Portable C compiler ? |
In #43, @raidenluikang requests that more macro guarding should be added on windows.
@raidenluikang Can you elaborate why this is necessary? Is the current state broken in any way?
The text was updated successfully, but these errors were encountered: