Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ad insert samples are not working #2

Open
marccastejon opened this issue Mar 30, 2016 · 0 comments
Open

Ad insert samples are not working #2

marccastejon opened this issue Mar 30, 2016 · 0 comments

Comments

@marccastejon
Copy link

In http://vm2.dashif.org/dash.js/samples/ad-insertion/scte.html, it seems this lib has moved
[...]

<script src="../../dist/dash.all.min.js"></script>

[...]

None of the Ad insertion samples seem to be working unfortunately .. I'm particularly interested in the SCTE35 one actually

Thanks
dsparacio pushed a commit that referenced this issue May 21, 2024
@technogeek00 @dsilhavy
Implementation of MPEG-DASH 5th Edition Patching Semantics (Dash-Indu…
d10013a 
…stry-Forum#3451)

* Implementation of MPEG-DASH 5th Edition Patching Semantics

- Full support for DASH specified xpath restrictions
- Support for add/replace/delete operations in patch
- Validation of Patch on receive
- Handling of empty Patch semantics

This commit is rebased first pass on to latest dash.js, includes the
additional fixes previously provided:
- Patch operation ironing fix (#1) - @thmatuza
- Xpath indexing and add attribute operation (#2) - @chanyk-joseph

* Addressing PR Feedback

* Add missing additional test case

Co-authored-by: Daniel Silhavy <daniel.silhavy@fokus.fraunhofer.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marccastejon