From f30ee6b6254f9bf57a9685c8ab641fb2f860bde5 Mon Sep 17 00:00:00 2001 From: Takashi Yano Date: Sun, 3 Mar 2024 14:09:07 +0900 Subject: [PATCH] Cygwin: pipe: Give up to use query_hdl for non-cygwin apps. Non-cygwin app may call ReadFile() which makes NtQueryObject() for ObjectNameInformation block in fhandler_pipe::get_query_hdl_per_process. Therefore, stop to try to get query_hdl for non-cygwin apps. Addresses: https://github.com/msys2/msys2-runtime/issues/202 Backported-from: https://inbox.sourceware.org/cygwin-patches/20240303050915.2024-1-takashi.yano@nifty.ne.jp/ Fixes: b531d6b06eeb ("Cygwin: pipe: Introduce temporary query_hdl.") Reported-by: Alisa Sireneva, Johannes Schindelin Reviewed-by: Signed-off-by: Takashi Yano Signed-off-by: Johannes Schindelin --- winsup/cygwin/fhandler/pipe.cc | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/winsup/cygwin/fhandler/pipe.cc b/winsup/cygwin/fhandler/pipe.cc index 283319cce8..9319a57792 100644 --- a/winsup/cygwin/fhandler/pipe.cc +++ b/winsup/cygwin/fhandler/pipe.cc @@ -1251,6 +1251,16 @@ fhandler_pipe::get_query_hdl_per_process (WCHAR *name, for (LONG i = (LONG) n_process - 1; i >= 0; i--) { + /* Non-cygwin app may call ReadFile() which makes NtQueryObject() + for ObjectNameInformation block. Therefore, stop to try to get + query_hdl for non-cygwin apps. */ + pid_t cygpid; + if (!(cygpid = cygwin_pid (proc_pids[i]))) + continue; + pinfo p (cygpid); + if (p && ISSTATE (p, PID_NOTCYGWIN)) + continue; + HANDLE proc = OpenProcess (PROCESS_DUP_HANDLE | PROCESS_QUERY_INFORMATION, 0, proc_pids[i]);