Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xService Unit Tests are not unit tests but are a "destructive" hybrid #214

Closed
PlagueHO opened this issue Aug 31, 2016 · 1 comment · Fixed by #216
Closed

xService Unit Tests are not unit tests but are a "destructive" hybrid #214

PlagueHO opened this issue Aug 31, 2016 · 1 comment · Fixed by #216
Labels
enhancement The issue is an enhancement request. in progress The issue is being actively worked on by someone.

Comments

@PlagueHO
Copy link
Member

I have created correct integration tests for this resource using the standard templates and methodology (which have exposed errors in the resource already). But the existing unit tests are not unit tests at all - they are a destructive integration test. There is very little useful coverage for this module (most helper functions are not covered at all).

So I'll re-write the unit tests from scratch so they're non-destructive.

@kwirkykat kwirkykat added enhancement The issue is an enhancement request. in progress The issue is being actively worked on by someone. labels Aug 31, 2016
@PlagueHO
Copy link
Member Author

PlagueHO commented Sep 2, 2016

Nearly completed this. Had network troubles last night so didn't get anything done on this. Aiming for completion tonight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement The issue is an enhancement request. in progress The issue is being actively worked on by someone.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants