Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Allow xService to enable/disable DesktopInteract #210

Closed
PlagueHO opened this issue Aug 30, 2016 · 4 comments · Fixed by #216
Closed

Feature: Allow xService to enable/disable DesktopInteract #210

PlagueHO opened this issue Aug 30, 2016 · 4 comments · Fixed by #216
Labels
enhancement The issue is an enhancement request. in progress The issue is being actively worked on by someone.

Comments

@PlagueHO
Copy link
Member

Some services when they are created/configured may require the DesktopInteract to be enabled/disabled. The DesktopInteract can only be enabled if the service account is LocalSystem.

Changing the Service account to anything other than LocalSystem with this setting enabled results in a "21" error as defined by https://msdn.microsoft.com/en-us/library/aa384901(v=vs.85).aspx.

This setting can be changed using the Change method of the Service CIM instance, so the change should be fairly straight forward.

I'd propose adding a new MOF parameter:

[Write, Description("The service can create or communicate with a window on the desktop. Must be false for services not running as LocalSystem.") ] boolean DesktopInteract;

It might be worth implementing a test for this scenario in the resource so that a more detailed instruction can be put in the logs because Status 21- Invalid Parameter isn't quite unclear.

@PlagueHO
Copy link
Member Author

Tagging @SteelCrusaders

@kwirkykat kwirkykat added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Aug 30, 2016
@PlagueHO
Copy link
Member Author

We're working on this now because it is needed by our enterprise.

@PlagueHO
Copy link
Member Author

I've found a problem with the tests for this resource that I'd like to fix:

The unit tests contain components that are actually integration tests and are therefore destructive. Unit tests should be mocked and not depend on creating an actual service (using the actual resource). This is a destructive test - unit tests should be non-destructive.

I propose that these tests be corrected (I'll do it as part of this change).

@PlagueHO
Copy link
Member Author

Regarding the "not" unit tests - I'm going to have to basically reconstruct them from scratch so they're actually unit tests (and not some Frankenstein's monster of Unit + Integration tests 😁). So I'll raise a separate issue for it.

@kwirkykat kwirkykat added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Sep 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement The issue is an enhancement request. in progress The issue is being actively worked on by someone.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants