Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Localization Strings in DSC resource PSM1 files #190

Open
PlagueHO opened this issue Aug 9, 2016 · 1 comment
Open

Remove Localization Strings in DSC resource PSM1 files #190

PlagueHO opened this issue Aug 9, 2016 · 1 comment
Labels
enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community.

Comments

@PlagueHO
Copy link
Member

PlagueHO commented Aug 9, 2016

Most of the resources contain two copies of the localization strings - one in the DSC Resource module file itself and one in the en-us folder in a PSD1 file.

This should not be required if the following code (or some variation) is used to read the localization file:

#region localizeddata
if (Test-Path "${PSScriptRoot}\${PSUICulture}")
{
    Import-LocalizedData `
        -BindingVariable LocalizedData `
        -Filename MSFT_xPackageResource.psd1 `
        -BaseDirectory "${PSScriptRoot}\${PSUICulture}"
}
else
{
    #fallback to en-US
    Import-LocalizedData `
        -BindingVariable LocalizedData `
        -Filename MSFT_xPackageResource.psd1 `
        -BaseDirectory "${PSScriptRoot}\en-US"
}
#endregion
@kwirkykat kwirkykat added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Aug 9, 2016
@kwirkykat kwirkykat removed the help wanted The issue is up for grabs for anyone in the community. label Feb 16, 2017
@kwirkykat kwirkykat self-assigned this Feb 16, 2017
@johlju johlju added the help wanted The issue is up for grabs for anyone in the community. label May 11, 2018
@johlju
Copy link
Member

johlju commented May 11, 2018

This should be resolved as part of PR #160 too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community.
Projects
None yet
Development

No branches or pull requests

3 participants