Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSFT_xWindowsOptionalFeature: Fix PSSA Issues #137

Closed
kwirkykat opened this issue May 17, 2016 · 3 comments
Closed

MSFT_xWindowsOptionalFeature: Fix PSSA Issues #137

kwirkykat opened this issue May 17, 2016 · 3 comments
Assignees
@kwirkykat
Labels
enhancement The issue is an enhancement request.

Comments

@kwirkykat
Copy link
Contributor

The PowerShell Script Analyzer issues in MSFT_xWindowsOptionalFeature need to be fixed.
This is the current result of running Invoke-ScriptAnalyzer:
image
@kwirkykat kwirkykat self-assigned this Jun 17, 2016
@kwirkykat
Copy link
Contributor Author

This is part of #160

@Dan1el42
Copy link
Contributor

I'm almost ready to submit a PR for this. Beside the fixes for the PSSA issues I've added an example, an integration test, updated the unit test and fixed long lines.

image

@Dan1el42
Copy link
Contributor

PR #198 submitted. AppVeyor build is green on my account (https://ci.appveyor.com/project/Dan1el42/xpsdesiredstateconfiguration/build/3.13.15.0)

@kwirkykat kwirkykat added the enhancement The issue is an enhancement request. label Aug 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kwirkykat kwirkykat

Labels
enhancement The issue is an enhancement request.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kwirkykat @Dan1el42