Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MountRequiredRegistryHives and SetupProvider functions in MSFT_xRegistryResource #114

Open
ArieHein opened this issue Apr 18, 2016 · 1 comment
Labels
enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community.

Comments

@ArieHein
Copy link

ArieHein commented Apr 18, 2016

Please swap to using Switch statements instead of If statements.
Its a bad progrmming practice and wasting time re-evaluating strings when its not needed.

same with $KeyName.Value.ToString(). Just set it ouside the logic section and then call it and manipulate it inside.

Updated: yes i know i can fork the repo and change the code myself and then ask for a pull request, i just dont have the capactiy to do that atm :(

@kwirkykat kwirkykat self-assigned this Jun 17, 2016
@kwirkykat
Copy link
Contributor

This resource (including the bad code) will get updated as part of #160

@kwirkykat kwirkykat added the enhancement The issue is an enhancement request. label Jun 17, 2016
@johlju johlju added the help wanted The issue is up for grabs for anyone in the community. label May 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community.
Projects
None yet
Development

No branches or pull requests

3 participants