Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Better support for self hosted master server #108

Closed
elmodor opened this issue Nov 27, 2022 · 1 comment
Closed

Feature: Better support for self hosted master server #108

elmodor opened this issue Nov 27, 2022 · 1 comment
Assignees
Labels
feature New feature or request
Milestone

Comments

@elmodor
Copy link
Contributor

elmodor commented Nov 27, 2022

Is your feature request related to a problem? Please describe.
Currently the URL and certificate of the master server is hardcoded. To be able to run your own master server, you would need to change the URL in the source doe and re-compile the client.

Describe the solution you'd like
To be able to change the server URL on the client I have two solutions in mind:

  • Add a launch parameter for the client to set the master server URL (e.g. --master-server https://url.com)
  • Add a configuration option inside the Options GUI to change the server URL (and/or certificate)

Furthermore we either have to disable the certificate validation, and/or add the possibility to also set the custom public certificate.

Describe alternatives you've considered
The alternative would be to compile the client again with the changed URL which is very cumbersome.

Additional context

@drwhut
Copy link
Owner

drwhut commented Nov 27, 2022

Thank you for the suggestion! Yeah, this makes sense to implement, and it shouldn't be too difficult.

I think it's best if the URL and certificate overrides are input through the command line arguments, e.g. --master-server and --ssl-certificate, since realistically it'll only be 'technical' users that will want to use them, and it may be too complicated for the average player in the options menu.

It also makes sense to print a warning if the master server is overridden, just to say "hey, you're not connecting to the official master server, proceed with caution".

@drwhut drwhut added this to the v0.1.0 milestone Nov 27, 2022
@drwhut drwhut self-assigned this Nov 27, 2022
@drwhut drwhut added the feature New feature or request label Nov 27, 2022
@drwhut drwhut closed this as completed in a74b9c0 Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants