Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) adding depends_on, image and detached fields to step #3072

Merged
merged 1 commit into from
Jun 22, 2021

Conversation

tphoney
Copy link

@tphoney tphoney commented Feb 26, 2021

No description provided.

@tphoney tphoney force-pushed the add_steps_fields branch 2 times, most recently from 8edee29 to b6483a2 Compare February 26, 2021 12:51
@bradrydzewski bradrydzewski marked this pull request as ready for review February 26, 2021 14:13
@tphoney tphoney marked this pull request as draft February 26, 2021 14:57
@tphoney tphoney marked this pull request as ready for review May 27, 2021 12:52
@tphoney
Copy link
Author

tphoney commented Jun 22, 2021

`➜ drone git:(add_steps_fields) task test-mysql
Error response from daemon: Cannot kill container: mysql: No such container: mysql
task: docker run -p 3306:3306 --env MYSQL_DATABASE=test --env MYSQL_ALLOW_EMPTY_PASSWORD=yes --name mysql --detach --rm mysql:5.7 --character-set-server=utf8mb4 --collation-server=utf8mb4_unicode_ci

Unable to find image 'mysql:5.7' locally
5.7: Pulling from library/mysql
69692152171a: Pull complete
1651b0be3df3: Pull complete
951da7386bc8: Pull complete
0f86c95aa242: Pull complete
37ba2d8bd4fe: Pull complete
6d278bb05e94: Pull complete
497efbd93a3e: Pull complete
a023ae82eef5: Pull complete
e76c35f20ee7: Pull complete
e887524d2ef9: Pull complete
ccb65627e1c3: Pull complete
Digest: sha256:a682e3c78fc5bd941e9db080b4796c75f69a28a8cad65677c23f7a9f18ba21fa
Status: Downloaded newer image for mysql:5.7
1639eff6b56c36ffc47f63731aa223aa6efc45ffce0a86a3fb2a82f3f5590b45
task: go test -count=1 github.com/drone/drone/store/batch
ok github.com/drone/drone/store/batch 1.109s
task: go test -count=1 github.com/drone/drone/store/batch2
ok github.com/drone/drone/store/batch2 0.152s
task: go test -count=1 github.com/drone/drone/store/build
ok github.com/drone/drone/store/build 0.240s
task: go test -count=1 github.com/drone/drone/store/cron
ok github.com/drone/drone/store/cron 0.078s
task: go test -count=1 github.com/drone/drone/store/logs
ok github.com/drone/drone/store/logs 0.067s
task: go test -count=1 github.com/drone/drone/store/perm
ok github.com/drone/drone/store/perm 0.058s
task: go test -count=1 github.com/drone/drone/store/repos
ok github.com/drone/drone/store/repos 0.104s
task: go test -count=1 github.com/drone/drone/store/secret
ok github.com/drone/drone/store/secret 0.107s
task: go test -count=1 github.com/drone/drone/store/secret/global
ok github.com/drone/drone/store/secret/global 0.054s
task: go test -count=1 github.com/drone/drone/store/stage
ok github.com/drone/drone/store/stage 0.087s
task: go test -count=1 github.com/drone/drone/store/step
ok github.com/drone/drone/store/step 0.063s
task: go test -count=1 github.com/drone/drone/store/template
ok github.com/drone/drone/store/template 0.065s
task: go test -count=1 github.com/drone/drone/store/user
ok github.com/drone/drone/store/user 0.093s
task: docker kill mysql
mysql
➜ drone git:(add_steps_fields) task test-postgres
task: docker kill postgres
Error response from daemon: Cannot kill container: postgres: No such container: postgres
task: docker run -p 5432:5432 --env POSTGRES_PASSWORD=postgres --env POSTGRES_USER=postgres --name postgres --detach --rm postgres:9-alpine

Unable to find image 'postgres:9-alpine' locally
9-alpine: Pulling from library/postgres
540db60ca938: Already exists
a3cb73039552: Pull complete
39855706e49a: Pull complete
caacf3a6c4e3: Pull complete
a43e10552cb9: Pull complete
5ad27a20815a: Pull complete
dabb4cf8dc15: Pull complete
817e5c24ebbc: Pull complete
71f8cfbd522d: Pull complete
Digest: sha256:03b0101f3c1a701befe0c83ea9b2bf6a35693a9471be0380ac5bd7fe2fd34102
Status: Downloaded newer image for postgres:9-alpine
0c3aadacc11dadf9f5a58f97dd87c9cd2a73877fe5600ad466d8447bbbbfdf28
task: go test -count=1 github.com/drone/drone/store/batch
ok github.com/drone/drone/store/batch 3.608s
task: go test -count=1 github.com/drone/drone/store/batch2
ok github.com/drone/drone/store/batch2 0.102s
task: go test -count=1 github.com/drone/drone/store/build
ok github.com/drone/drone/store/build 0.159s
task: go test -count=1 github.com/drone/drone/store/cron
ok github.com/drone/drone/store/cron 0.046s
task: go test -count=1 github.com/drone/drone/store/logs
ok github.com/drone/drone/store/logs 0.044s
task: go test -count=1 github.com/drone/drone/store/perm
ok github.com/drone/drone/store/perm 0.039s
task: go test -count=1 github.com/drone/drone/store/repos
ok github.com/drone/drone/store/repos 0.058s
task: go test -count=1 github.com/drone/drone/store/secret
ok github.com/drone/drone/store/secret 0.060s
task: go test -count=1 github.com/drone/drone/store/secret/global
ok github.com/drone/drone/store/secret/global 0.033s
task: go test -count=1 github.com/drone/drone/store/stage
ok github.com/drone/drone/store/stage 0.050s
task: go test -count=1 github.com/drone/drone/store/step
ok github.com/drone/drone/store/step 0.039s
task: go test -count=1 github.com/drone/drone/store/template
ok github.com/drone/drone/store/template 0.032s
task: go test -count=1 github.com/drone/drone/store/user
ok github.com/drone/drone/store/user 0.050s
postgres
➜ drone git:(add_steps_fields)
`
Passing mysql / postres tests too

@eoinmcafee00
Copy link

LGTM

@eoinmcafee00 eoinmcafee00 merged commit 0c53e7d into harness:master Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants