Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All images are subject to link rot #93

Closed
seanpm2001 opened this issue May 22, 2023 · 2 comments · Fixed by #103
Closed

All images are subject to link rot #93

seanpm2001 opened this issue May 22, 2023 · 2 comments · Fixed by #103

Comments

@seanpm2001
Copy link
Contributor

Is it possible to add a /media/ folder, and link to the images from here? It is not the best idea to base most of a repository off of a resource that can go down at any time for any reason. I don't think it would increase the repository size by very much either, especially if the images are in SVG format. I have seen many prominent images from camo.githubusercontent.com suddenly stop working, even from Microsoft-owned repositories themselves!
@drknzz
Copy link
Owner

drknzz commented May 27, 2023

Good idea, I'd accept a PR from someone who wants to do it.

@seanpm2001
Copy link
Contributor Author

I have opened a pull request to fix this issue: #103

@drknzz drknzz linked a pull request Jun 12, 2023 that will close this issue
Fixing link rot by adding a media folder #103
Merged
@drknzz drknzz closed this as completed Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing link rot by adding a media folder seanpm2001/DrKnzz_GitHub-Achievements
2 participants
@drknzz @seanpm2001